Opened 10 years ago

Closed 10 years ago

#1744 closed New Feature (fixed)

FCKeditor.java browser detection enhancement

Reported by: Michael Osipov Owned by:
Priority: Normal Milestone: FCKeditor.Java 2.4
Component: Server : Java Version:
Keywords: Cc:

Attachments (1)

FCKeditor.java.patch (1.9 KB) - added by Michael Osipov 10 years ago.

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Michael Osipov

Attachment: FCKeditor.java.patch added

comment:1 Changed 10 years ago by Michael Osipov

FCKeditor.java browser detection enhancement Private: (?) No While trying out the Java/JSP-wrapper to FCKeditor I noticed that it didn't work with my version of Firefox because of it's user agent (Resulted in a ArrayNullPointerException):

Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.8.0.2) Gecko/Debian-1.5.dfsg+1.5.0.2-3 Firefox/1.5.0.2

Anyhow; I reworked FCKeditor.java to use the "rv:" field by a regular expression instead of "get whatever's 6 characters after the beginning of the string 'gecko'".

The patch is tested on

  • Firefox 1.5.0.2 / Mozilla/5.0 (X11; U; Linux i686

(x86_64); en-US; rv:1.8.0.2) Gecko/Debian-1.5.dfsg+1.5.0.2-3 Firefox/1.5.0.2

  • Firefox 1.5.0.2 / Mozilla/5.0 (Windows; U; Windows NT

5.1; en-US; rv:1.8.0.2) Gecko/20060308 Firefox/1.5.0.2

  • Mozilla 1.7.12
  • Epiphany 1.8.3

(Stated in patch...)

Patch is against the file FCKeditor.java, v2.3.

BR. Henrik Johansson

comment:2 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Description: modified (diff)

comment:3 Changed 10 years ago by Thilo Schwarz

Milestone: FCKeditor.Java 2.4
Resolution: fixed
Status: newclosed

Browser detection is completely rewritten and should work as expected.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy