Opened 11 years ago

Closed 11 years ago

#1746 closed Task (fixed)

Implement JUnit tests for browser compatibility check

Reported by: Thilo Schwarz Owned by: Thilo Schwarz
Priority: Must have (possibly next milestone) Milestone: FCKeditor.Java 2.4
Component: Server : Java Version:
Keywords: fixed in svn#1547 Cc:

Description (last modified by Thilo Schwarz)

We need some exemplary JUnit tests for the class Compatibility to ensure, the browser compatibility check works fine.

Change History (5)

comment:1 Changed 11 years ago by Thilo Schwarz

Status: newassigned

comment:2 Changed 11 years ago by Frederico Caldeira Knabben

This is quite a difficult thing to handle in JUnit, as the test code also needs to identify the browser with a code that is basically similar to the code used in FCKeditor.Java for the browser check.

The only possible automation would be testing the compatibility checks over a list of browser user agent strings, which means that the check code should be separated from the user agent string retrieval code.

comment:3 in reply to:  2 Changed 11 years ago by Thilo Schwarz

Description: modified (diff)
Summary: Implement JUnit tests for browser compatibilty checkImplement JUnit tests for browser compatibility check

Replying to fredck:

This is quite a difficult thing to handle in JUnit, as the test code also needs to identify the browser with a code that is basically similar to the code used in FCKeditor.Java for the browser check.

The only possible automation would be testing the compatibility checks over a list of browser user agent strings, which means that the check code should be separated from the user agent string retrieval code.

That's exactly what I want to do! I don't want to check the agent string retrieval code.

My Compatibility class gets only one argument, the user agent string. And so it is possible to check this class over a list of browser agent strings, as you said. So we can ensure, that the compatibility check works as it expected for a list of user agent strings. And that would be very helpful!

Do you have some exemplary user agent strings, for negative and positive checks? Otherwise I'll take some from http://www.zytrax.com/tech/web/browser_ids.htm.

comment:4 Changed 11 years ago by Thilo Schwarz

Description: modified (diff)

comment:5 Changed 11 years ago by Thilo Schwarz

Keywords: fixed in svn#1547 added
Resolution: fixed
Status: assignedclosed

fixed in svn#1547

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy