Opened 11 years ago

Closed 11 years ago

#2349 closed Bug (fixed)

[IE] Dialog system is broken with rtl

Reported by: Dekel Owned by: Martin Kou
Priority: Normal Milestone: FCKeditor 2.6.4
Component: UI : Dialogs Version: FCKeditor 2.6.3 Beta
Keywords: Confirmed IE Review+ Cc:

Description

When using RTL language on IE6, the new dialog system is broken (there are two scroll bars, and some of the dialog is missing).

The image attached is using the nightly build, with IE6 and 'he' in the accept_language.
Can be done also with:

FCKConfig.AutoDetectLanguage	= false ;
FCKConfig.DefaultLanguage	= 'he' ;

in the fckconfig.js file.

Attachments (3)

fck_rtl_dialog_ie6bug.png (13.7 KB) - added by Dekel 11 years ago.
rtl_dialog.patch (734 bytes) - added by Dekel 11 years ago.
Fix for this bug
2349.patch (1.3 KB) - added by Martin Kou 11 years ago.

Download all attachments as: .zip

Change History (12)

Changed 11 years ago by Dekel

Attachment: fck_rtl_dialog_ie6bug.png added

comment:1 Changed 11 years ago by Wojciech Olchawa

Keywords: Confirmed IE added; dialog rtl hebrew removed
Summary: New dialog system is broken with rtl on ie6[IE] Dialog system is broken with rtl
Version: FCKeditor 2.6.3 Beta

Confirmed using FCKeditor 2.6.3 beta and the latest SVN version in IE6. IE7 and FF seem no to be affected.

comment:2 Changed 11 years ago by Martin Kou

The bug happened from 2.6.1 but didn't happen in 2.6. So some changes in 2.6.1 must have caused this.

Changed 11 years ago by Dekel

Attachment: rtl_dialog.patch added

Fix for this bug

comment:3 Changed 11 years ago by Dekel

Actually the bug does happen in 2.6 (and even in 2.6beta). Attached a patch that fixes this bug. The patch was checked with the following browsers:

  • ie6 - he/en
  • ie7 - he/en
  • ff2 - he/en
  • ff3 - he/en

(all of those on a windows xp machine).

comment:4 Changed 11 years ago by Alfonso Martínez de Lizarrondo

Keywords: HasPatch added

comment:5 Changed 11 years ago by Frederico Caldeira Knabben

Milestone: FCKeditor 2.6.4

comment:6 Changed 11 years ago by Martin Kou

Owner: set to Martin Kou
Status: newassigned

Changed 11 years ago by Martin Kou

Attachment: 2349.patch added

comment:7 Changed 11 years ago by Martin Kou

Keywords: Review? added

Thanks Dekel, your patch works. I've only added the change message to the new patch.

comment:8 Changed 11 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review+ added; HasPatch Review? removed

comment:9 Changed 11 years ago by Martin Kou

Resolution: fixed
Status: assignedclosed

Fixed with [2560].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy