Double Iframes for FCKeditor

[Jeff]

Possibly asked and answered.

Sorry I don't have time to download and verify bugs, and I'm not sure what component this even belongs to.

We're using Drupal 5.6 with the 5.x-2.2-beta2 module of FCKeditor.

What I suspect is that the error is only visible with this combination.

What I know is the error is completely avoidable.

in fckeditor.js

in function FCKeditor.ReplaceTextarea()

Add the following code at the very beginning:

---

var oIFrame = document.getElementById(this.InstanceName + '_Frame');

if (!oIFrame) {

---

Then add the following code at the very end:

---

}

---

This protective if-block will prevent any duplicates from be formed, since the code inside that if-block creates the iframe with then name: this.InstanceName + '_Frame'.

Yes, it's probably the fault of some other library further up. Shouldn't matter. Code should do the right thing, and duplicate editors is bad. This won't appreciably affect speed of the component, and is a good thing.

If I'm reporting this the wrong way, sorry, if I'm reporting to to the wrong place, double my-bad. But there you go.

Jeff

[Jeff]

sorry the funny formating messed up the Frame that's supposed to be three '_' underscores before the text 'Frame'.

[Alfonso Martínez de Lizarrondo]

As the oIframe variable isn't used after that check I think that the code can be further simplified to

if ( document.getElementById( this.InstanceName + '___Frame' ) ) 
 	return ; 

you also need to add the change for the what's new file

[Alfonso Martínez de Lizarrondo]

and another detail: you should assign to yourself the bugs where you are working.

[Artur Formella]

Fixed with [2558]