Merge Cells removes attributes from tr in table

[Matthew Leffler]

When two cells are merged the class attribute on the tr(s) in the table is removed.

Steps to reproduce:

Click on the source button and remove the existing code and paste in the following

<table>
    <tbody>
        <tr class="sample_class">
            <td>Test cell</td>
            <td>Test cell 2</td>
        </tr>
    </tbody>
</table>

Click the source button again to exit source view and click in the two cells. Right-click and select merge cells (or merge right). Click source again and the class attribute is removed from the tr.

This is reproducible in either the demo on FCKeditor.net or the nightly build. It reproduces in FF3, FF2, IE7, and IE6 and doesn't seem to be dependent on platform used.

[Alfonso Martínez de Lizarrondo]

The problem is the FCKTableHandler._InstallTableMap function that does removes all the rows in the table and then recreates them again, so any attribute in any row affected by the table operations (merge and split cells) will be lost.

It's not related to the Styles component, but to the tables handling, the code was introduced with [690], part of 2.5beta

[shri]

Replying to alfonsoml:

Adding a patch for this defect. Tested it on FireFox 2.0 and IE 6 and seems to have fixed the issue.

[shri]

Revised patch

[Alfonso Martínez de Lizarrondo]

Having a function named CopyAttributesToArray that returns an object looks really strange. The comments should reflect the functionality in a generic way (don't use "on the row element", or that "could probably be used in other scenarios")

To me it looks strange that the functions added to fckdomtools are asymetric. One takes care of doing all the loop, but the second one only applies one attribute at a time.

The logic about rowCount is flawed. You can test that merging some cells in this table changes the classes:

<table cellspacing="1" cellpadding="1" border="1" width="200">
    <tbody>
        <tr class="odd">
            <td>&nbsp;</td>
            <td>&nbsp;</td>
        </tr>
        <tr>
            <td>&nbsp;</td>
            <td>&nbsp;</td>
        </tr>
        <tr class="odd">
            <td>&nbsp;</td>
            <td>&nbsp;</td>
        </tr>
    </tbody>
</table>

[Koen Willems]

I added a litle patch to preserve classes on rows and so on.

Regards, Koen Willems

[Koen Willems]

Oops ... please wait reviewing this patch. I stumbled upon some problems with another patch i'm making.

[Koen Willems]

Ok, go ahead ... the patch is working!

[Matthew Leffler]

Closing as this WFM on the CKEditor trunk.