the code should try to use Array.indexOf if it does exist

[Alfonso Martínez de Lizarrondo]

see ​http://developer.mozilla.org/En/Core_JavaScript_1.5_Reference:Objects:Array:indexOf and ​http://www.prototypejs.org/api/array/indexof

The function in CKEDITOR.tools should be adjusted to call the native implementation if it is detected.

[Frederico Caldeira Knabben]

1. There is no need to do a typeof check. You can do if( array.indexOf ). Less code and better performance (no string comparison).

2. If we'll be using the browser implementation, we need to make our custom implementation work in the same way as the specifications. It means that strict equality (===) checks must be used.

[Alfonso Martínez de Lizarrondo]

Also, my idea was that instead of checking how to execute it everytime, at initialization time the detection was executed on Array only once, similar to other methods in the tools.js

[Frederico Caldeira Knabben]

Replying to alfonsoml:

Also, my idea was that instead of checking how to execute it everytime, at initialization time the detection was executed on Array only once, similar to other methods in the tools.js

Good point... that would be even better.

[Artur Formella]

In Google Chrome there is no Array.indexOf() but [].indexOf() works. What do you think about this code?

 if ( Array.indexOf || [].indexOf ) {	

[Frederico Caldeira Knabben]

Being this executed once only, when loading the code, it would be acceptable to have the ( [].indexOf ) check only (please add a comment about it, so we can understand the reason why). We don't need the Array.indexOf check then.

You can also use a ​conditional operator, instead of a private function to simplify the code. Something like this:

indexOf :
	[].indexOf ?
		function( array, entry )
		{
			...
		}
	:
		function( array, entry )
		{
			...
		}

Check CKEDITOR.dom.element.getComputedStyle for an example.

[Frederico Caldeira Knabben]

We are almost there...

return index = array.indexOf( entry ); 

I think that's "index" var has nothing to do here. It should be simply:

return array.indexOf( entry ); 

[Artur Formella]

Oh. yes. Now it should be ok.

[Garry Yao]

My idea is if we can use Array.prototype.indexOf for feature detection.

[Artur Formella]

Replying to garry.yao:

My idea is if we can use Array.prototype.indexOf for feature detection.

It works in Opera, FF2, FF3, IE7, Chrome and Safari.

[Artur Formella]

Fixed with [3088]