Opened 9 years ago

Closed 9 years ago

#2597 closed Bug (fixed)

Safari: drop from outside the editor is disabled

Reported by: Alfonso Martínez de Lizarrondo Owned by: Martin Kou
Priority: Normal Milestone: FCKeditor 2.6.4
Component: General Version: FCKeditor 2.5 Beta
Keywords: Confirmed Safari Review+ Cc:

Description

Since the introduction of [589] the external drop of elements in FCKeditor is disabled in Safari.

That's meant to respect the ForcePasteAsPlainText setting, but every drop is always disabled in this code:

 var cancelHandler = function( evt ){ evt.returnValue = false ; } 
 this.EditorDocument.addEventListener( 'dragenter', cancelHandler, true ) ; 
 this.EditorDocument.addEventListener( 'dragover', cancelHandler, true ) ; 
 this.EditorDocument.addEventListener( 'drop', this._ExecDrop, true ) ;

Attachments (1)

2597.patch (1.7 KB) - added by Martin Kou 9 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 9 years ago by Alfonso Martínez de Lizarrondo

Keywords: Confirmed Safari added

comment:2 Changed 9 years ago by Martin Kou

Owner: set to Martin Kou
Status: newassigned

Changed 9 years ago by Martin Kou

Attachment: 2597.patch added

comment:3 Changed 9 years ago by Martin Kou

Keywords: Review? added

comment:4 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:5 Changed 9 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review- added; Review+ removed

One thing that I forgot about this:

Why are we watching the dragover and drop events only in Safari?
Wouldn't it be better to set those listeners for every browser so that when they implement the Drag and drop API it also works for them? (I think that Firefox 3.1 will implement it)

removing the review+ just to get the feedback

comment:6 Changed 9 years ago by Martin Kou

Firefox 3 already supports the dragover and the drop event, but its behavior of canceling them is different from Safari - if you just use Safari's code to handle the IsGecko case, the paste as plain text dialog wouldn't appear at all.

comment:7 Changed 9 years ago by Martin Kou

Keywords: Review? added; Review- removed

comment:8 Changed 9 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review+ added; Review? removed

ok, thanks for the reply

comment:9 Changed 9 years ago by Martin Kou

Resolution: fixed
Status: assignedclosed

Fixed with [2608].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy