Safari: drop from outside the editor is disabled

[Alfonso Martínez de Lizarrondo]

Since the introduction of [589] the external drop of elements in FCKeditor is disabled in Safari.

That's meant to respect the ForcePasteAsPlainText setting, but every drop is always disabled in this code:

 var cancelHandler = function( evt ){ evt.returnValue = false ; } 
 this.EditorDocument.addEventListener( 'dragenter', cancelHandler, true ) ; 
 this.EditorDocument.addEventListener( 'dragover', cancelHandler, true ) ; 
 this.EditorDocument.addEventListener( 'drop', this._ExecDrop, true ) ;

[Alfonso Martínez de Lizarrondo]

One thing that I forgot about this:

Why are we watching the dragover and drop events only in Safari?
Wouldn't it be better to set those listeners for every browser so that when they implement the Drag and drop API it also works for them? (I think that Firefox 3.1 will implement it)

removing the review+ just to get the feedback

[Martin Kou]

Firefox 3 already supports the dragover and the drop event, but its behavior of canceling them is different from Safari - if you just use Safari's code to handle the IsGecko case, the paste as plain text dialog wouldn't appear at all.

[Alfonso Martínez de Lizarrondo]

ok, thanks for the reply

[Martin Kou]

Fixed with [2608].

Click here for more info about our SVN system.