Ticket #2597 (closed Bug: fixed)

Opened 6 years ago

Last modified 5 years ago

Safari: drop from outside the editor is disabled

Reported by: alfonsoml Owned by: martinkou
Priority: Normal Milestone: FCKeditor 2.6.4
Component: General Version: FCKeditor 2.5 Beta
Keywords: Confirmed Safari Review+ Cc:

Description

Since the introduction of [589] the external drop of elements in FCKeditor is disabled in Safari.

That's meant to respect the ForcePasteAsPlainText setting, but every drop is always disabled in this code:

 var cancelHandler = function( evt ){ evt.returnValue = false ; } 
 this.EditorDocument.addEventListener( 'dragenter', cancelHandler, true ) ; 
 this.EditorDocument.addEventListener( 'dragover', cancelHandler, true ) ; 
 this.EditorDocument.addEventListener( 'drop', this._ExecDrop, true ) ;

Attachments

2597.patch (1.7 KB) - added by martinkou 6 years ago.

Change History

comment:1 Changed 6 years ago by alfonsoml

  • Keywords Confirmed Safari added

comment:2 Changed 6 years ago by martinkou

  • Status changed from new to assigned
  • Owner set to martinkou

Changed 6 years ago by martinkou

comment:3 Changed 6 years ago by martinkou

  • Keywords Review? added

comment:4 Changed 5 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:5 Changed 5 years ago by alfonsoml

  • Keywords Review- added; Review+ removed

One thing that I forgot about this:

Why are we watching the dragover and drop events only in Safari?
Wouldn't it be better to set those listeners for every browser so that when they implement the Drag and drop API it also works for them? (I think that Firefox 3.1 will implement it)

removing the review+ just to get the feedback

comment:6 Changed 5 years ago by martinkou

Firefox 3 already supports the dragover and the drop event, but its behavior of canceling them is different from Safari - if you just use Safari's code to handle the IsGecko case, the paste as plain text dialog wouldn't appear at all.

comment:7 Changed 5 years ago by martinkou

  • Keywords Review? added; Review- removed

comment:8 Changed 5 years ago by alfonsoml

  • Keywords Review+ added; Review? removed

ok, thanks for the reply

comment:9 Changed 5 years ago by martinkou

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [2608].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy