Opened 9 years ago

Closed 9 years ago

#2603 closed New Feature (fixed)

Set EMailProtection to none by default.

Reported by: Wiktor Walc Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone: FCKeditor 2.6.4
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

Ok, I have noticed that this is a problem too late, but I guess we can still turn it off.

Reasons why I think it should be disabled:

  • it is not documented well (that can be fixed)
  • links are not usable if javascript is disabled (can't be fixed)
  • there are sites that filter posted content and strip code that looks like a potential XSS attack (via HTML Purifier for example), thus it doesn't work there even if javascript is enabled
  • it is a major change between last stable release and when upgrading from previous minor release most people expect no suprises

I think we have made a mistake by enabling it by default, but it may bee too late to change this. Anyway I'm posting this here for consideration.

Attachments (1)

2603.patch (1.2 KB) - added by Alfonso Martínez de Lizarrondo 9 years ago.
Proposed patch

Download all attachments as: .zip

Change History (7)

comment:1 Changed 9 years ago by Wiktor Walc

Summary: Set EmailProtection set to none by default.Set EMailProtection to none by default.

comment:2 Changed 9 years ago by Alfonso Martínez de Lizarrondo

In http://dev.fckeditor.net/ticket/2488#comment:3 I already said that I think that the default should be no encryption, so I agree.

comment:3 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Confirmed added; Discussion removed

Ok... let's disable it by default, as long as the editor is able to handle link previously encrypted.

Changed 9 years ago by Alfonso Martínez de Lizarrondo

Attachment: 2603.patch added

Proposed patch

comment:4 Changed 9 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added
Owner: set to Alfonso Martínez de Lizarrondo
Status: newassigned

comment:5 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:6 Changed 9 years ago by Alfonso Martínez de Lizarrondo

Resolution: fixed
Status: assignedclosed

Fixed with [2779]

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy