Opened 9 years ago

Closed 9 years ago

#2634 closed Bug (fixed)

Bug with FCKXhtml.SpecialBlocks

Reported by: James Cooke Owned by: Martin Kou
Priority: Normal Milestone: FCKeditor 2.6.4
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Review+ Cc:

Description

When SpecialBlocks have child nodes, the call to AddItem fails, as it was removed recently I believe.

This can be replicated with the manual fckxhtml test.

I'll attach a patch I believe resolves this momentarily.

Attachments (1)

2634.patch (1.1 KB) - added by James Cooke 9 years ago.
Patch for bug.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by James Cooke

Attachment: 2634.patch added

Patch for bug.

comment:1 Changed 9 years ago by Martin Kou

Keywords: Review+ added
Milestone: FCKeditor 2.6.4
Owner: set to Martin Kou
Status: newassigned
Version: SVN

comment:2 Changed 9 years ago by Martin Kou

The AddItem() function was removed in [2570]. The two items in the patch are what we missed in #2516's code review. This should be committed ASAP.

comment:3 Changed 9 years ago by Martin Kou

Resolution: fixed
Status: assignedclosed

Fixed with [2619].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy