Fix autogrow in Firefox

[slessard]

Autogrow doesn't work in Firefox

[slessard]

Patch

[slessard]

Attached patch for the issue.

[Michael Osipov]

Thanks for your contribution, I hope it will be quickly reviewed.

[Martin Kou]

The proposed patch has some problems:

1. The RemoveOverflow() function scrolls the editing area to the top in Firefox 3 whenever it is called, it must be removed.
2. I'm not really sure what the "+ 16" in line 97 does... it gives me an editor frame that's 16px longer than needed in my tests. I guess the patch author needed some way of accounting for the body margin?

Proposing a new patch. It should work in IE, Firefox and Safari for Standards mode and Quirks mode documents. I haven't found a way to make it work in Opera due to browser bugs.

[Frederico Caldeira Knabben]

• The FCKAutoGrow variable declaration misses the "var" statement.
• If you really want to put everything in an object, please use a literal object declaration (like var FCKAutoGrow = { MIN_HEIGHT : ..., Check : ..., ...} ;).
• The changelog entry is missing.

Other than these details, the code looks good, and it works well. It should be read for Review+ after the above fixes.

[Alfonso Martínez de Lizarrondo]

#2350 did suggest another patch.

There might be more tickets about the same problem

[Martin Kou]

Fixed with [2793].

Click here for more info about our SVN system.