Opened 9 years ago

Closed 9 years ago

#2696 closed Bug (fixed)

Fix autogrow in Firefox

Reported by: slessard Owned by: Martin Kou
Priority: Normal Milestone: FCKeditor 2.6.4
Component: General Version: FCKeditor 2.6.3
Keywords: Review+ Cc:

Description

Autogrow doesn't work in Firefox

Attachments (3)

autogrow-firefox.patch (4.6 KB) - added by slessard 9 years ago.
Patch
2696.patch (4.3 KB) - added by Martin Kou 9 years ago.
2696_2.patch (5.2 KB) - added by Martin Kou 9 years ago.

Download all attachments as: .zip

Change History (13)

Changed 9 years ago by slessard

Attachment: autogrow-firefox.patch added

Patch

comment:1 Changed 9 years ago by slessard

Attached patch for the issue.

comment:2 Changed 9 years ago by Michael Osipov

Keywords: Review? added

Thanks for your contribution, I hope it will be quickly reviewed.

comment:3 Changed 9 years ago by Martin Kou

Owner: set to Martin Kou
Status: newassigned

comment:4 Changed 9 years ago by Martin Kou

Milestone: FCKeditor 2.6.4

comment:5 Changed 9 years ago by Martin Kou

The proposed patch has some problems:

  1. The RemoveOverflow() function scrolls the editing area to the top in Firefox 3 whenever it is called, it must be removed.
  2. I'm not really sure what the "+ 16" in line 97 does... it gives me an editor frame that's 16px longer than needed in my tests. I guess the patch author needed some way of accounting for the body margin?

Proposing a new patch. It should work in IE, Firefox and Safari for Standards mode and Quirks mode documents. I haven't found a way to make it work in Opera due to browser bugs.

Changed 9 years ago by Martin Kou

Attachment: 2696.patch added

comment:6 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed
  • The FCKAutoGrow variable declaration misses the "var" statement.
  • If you really want to put everything in an object, please use a literal object declaration (like var FCKAutoGrow = { MIN_HEIGHT : ..., Check : ..., ...} ;).
  • The changelog entry is missing.

Other than these details, the code looks good, and it works well. It should be read for Review+ after the above fixes.

Changed 9 years ago by Martin Kou

Attachment: 2696_2.patch added

comment:7 Changed 9 years ago by Martin Kou

Keywords: Review? added; Review- removed

comment:8 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:9 Changed 9 years ago by Alfonso Martínez de Lizarrondo

#2350 did suggest another patch.

There might be more tickets about the same problem

comment:10 Changed 9 years ago by Martin Kou

Resolution: fixed
Status: assignedclosed

Fixed with [2793].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy