Image upload dialog freezes on IE when uploaded file is missing (or server response is invalid)

[thiloplanz]

In IE you can directly enter the file name to be uploaded. When entering a path to a non-existing file, the upload dialog shows a progress bar that never finishes.

Clicking on the [x] icon to abort the image upload does not work, so there is no way to continue editing the text.

Note: the same also happens when a response from the server is malformed. In this case, however, the request does not seem to reach the server, so that there is no way to fix it server-side.

Note: other browsers do not let you enter the file name directly, so that this problem is much less likely to occur (probably only when deleting the file after selecting it). Also, at least on Firefox, it is possible to close the image upload dialog while the progress bar is still on.

[thiloplanz]

I think I figured it out.

It is possible to detect the problem on the client, by not using the normal form submit, but by having the onSubmit handler that stops the submit (returns false) and instead submits the form itself using form.submit(). If the file is missing, there will be an exception.

function CheckUpload()
{
        // ... snip ....

        // Show animation
        window.parent.Throbber.Show( 100 ) ;
        GetE( 'divUpload' ).style.display  = 'none' ;

        try{
                GetE('frmUpload').submit();
        }
        catch (e){
                OnUploadCompleted( 1, null, null, 'File not found' ) ;
        }

        return false ;
}

[Artur Formella]

I was unable to confirm this bug. I have "Invalid file type" alert (IE7@Vista32).

Sample file path:

c:\rev\fregaqf\frcegre\ge\rtesahtr.jpg

(this file doesn't exist)

Could you provide more information?

[thiloplanz]

There seems to be a difference between just the file not existing versus the whole path not existing. I just tried "a.gif" without any path.

[Artur Formella]

Yes. URL without existing directory (i.e "a.gif") doesn't work. Dialogs before 2.6.1 just do nothing.