Opened 11 years ago

Last modified 11 years ago

#2716 confirmed Bug

Image upload dialog freezes on IE when uploaded file is missing (or server response is invalid)

Reported by: thiloplanz Owned by:
Priority: Normal Milestone:
Component: UI : Dialogs Version: FCKeditor 2.6.1
Keywords: IE Cc:

Description

In IE you can directly enter the file name to be uploaded. When entering a path to a non-existing file, the upload dialog shows a progress bar that never finishes.

Clicking on the [x] icon to abort the image upload does not work, so there is no way to continue editing the text.

Note: the same also happens when a response from the server is malformed. In this case, however, the request does not seem to reach the server, so that there is no way to fix it server-side.

Note: other browsers do not let you enter the file name directly, so that this problem is much less likely to occur (probably only when deleting the file after selecting it). Also, at least on Firefox, it is possible to close the image upload dialog while the progress bar is still on.

Change History (4)

comment:1 Changed 11 years ago by thiloplanz

I think I figured it out.

It is possible to detect the problem on the client, by not using the normal form submit, but by having the onSubmit handler that stops the submit (returns false) and instead submits the form itself using form.submit(). If the file is missing, there will be an exception.

function CheckUpload()
{
        // ... snip ....

        // Show animation
        window.parent.Throbber.Show( 100 ) ;
        GetE( 'divUpload' ).style.display  = 'none' ;

        try{
                GetE('frmUpload').submit();
        }
        catch (e){
                OnUploadCompleted( 1, null, null, 'File not found' ) ;
        }

        return false ;
}

comment:2 Changed 11 years ago by Artur Formella

Keywords: Pending WorksForMe added

I was unable to confirm this bug. I have "Invalid file type" alert (IE7@Vista32).

Sample file path:

c:\rev\fregaqf\frcegre\ge\rtesahtr.jpg

(this file doesn't exist)

Could you provide more information?

comment:3 Changed 11 years ago by thiloplanz

There seems to be a difference between just the file not existing versus the whole path not existing. I just tried "a.gif" without any path.

comment:4 Changed 11 years ago by Artur Formella

Keywords: Confirmed added; Pending WorksForMe removed
Version: FCKeditor 2.6.3FCKeditor 2.6.1

Yes. URL without existing directory (i.e "a.gif") doesn't work. Dialogs before 2.6.1 just do nothing.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy