Opened 10 years ago

Closed 10 years ago

#2785 closed Bug (fixed)

Move plugins specific configurations to the plugins files

Reported by: Frederico Caldeira Knabben Owned by: Artur Formella
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

The default configurations for each plugin must be defined inside each plugin.js file, not into the core config.js file. Just core settings should go into that file.

The motivation behind it is that the core config.js file will be always part of the compressed version of CKEditor. So, if I reduce the number of plugins when building the compressed version, I should not have plugin specific stuff being included in the process.

Attachments (2)

2785.patch (45.9 KB) - added by Artur Formella 10 years ago.
2785_2.patch (54.7 KB) - added by Artur Formella 10 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 10 years ago by Artur Formella

Owner: set to Artur Formella

Changed 10 years ago by Artur Formella

Attachment: 2785.patch added

comment:2 Changed 10 years ago by Artur Formella

Keywords: Review? added

comment:3 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

The patch is almost good. Just two small things:

  • The "magnetDistance", "backgroundCoverOpacity" and "backgroundCoverColor" configurations must also be moved. They are specific to the "dialog" plugin.
  • Code style: All configuration setting statements are missing the semicolon after the literal object definition. (e.g. line 38 in plugins/table/plugin.js)

Another detail... please always create the patch from the root of the prototype, not the _source folder.

comment:4 Changed 10 years ago by Artur Formella

Keywords: Review? added; Review- removed

Changed 10 years ago by Artur Formella

Attachment: 2785_2.patch added

comment:5 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:6 Changed 10 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: newclosed

Fixed with [2938]. Sorry for taking the commit to me... just to avoid release delay.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy