Opened 16 years ago
Closed 16 years ago
#2785 closed Bug (fixed)
Move plugins specific configurations to the plugins files
Reported by: | Frederico Caldeira Knabben | Owned by: | Artur Formella |
---|---|---|---|
Priority: | Must have (possibly next milestone) | Milestone: | CKEditor 3.0 |
Component: | General | Version: | |
Keywords: | Confirmed Review+ | Cc: |
Description
The default configurations for each plugin must be defined inside each plugin.js file, not into the core config.js file. Just core settings should go into that file.
The motivation behind it is that the core config.js file will be always part of the compressed version of CKEditor. So, if I reduce the number of plugins when building the compressed version, I should not have plugin specific stuff being included in the process.
Attachments (2)
Change History (8)
comment:1 Changed 16 years ago by
Owner: | set to Artur Formella |
---|
Changed 16 years ago by
Attachment: | 2785.patch added |
---|
comment:2 Changed 16 years ago by
Keywords: | Review? added |
---|
comment:3 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
comment:4 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
Changed 16 years ago by
Attachment: | 2785_2.patch added |
---|
comment:5 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
comment:6 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Fixed with [2938]. Sorry for taking the commit to me... just to avoid release delay.
The patch is almost good. Just two small things:
Another detail... please always create the patch from the root of the prototype, not the _source folder.