Opened 11 years ago

Closed 11 years ago

#2803 closed Bug (fixed)

Separate default values from initial values in dialogs

Reported by: Martin Kou Owned by: Martin Kou
Priority: Normal Milestone: CKEditor 3.0
Component: UI : Dialogs Version: SVN (FCKeditor) - Retired
Keywords: Review+ Cc:

Description

Instead of treating the initial values in dialog opening as another set of default values, initial values in a dialog should be stored and deleted as a kind of its own. This removes the need for a default value stack in the dialogui and dialog plugin, also removes the need to "pop" default values when a dialog closes.

Attachments (2)

2803.patch (7.9 KB) - added by Martin Kou 11 years ago.
2803_2.patch (4.4 KB) - added by Martin Kou 11 years ago.

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by Martin Kou

Attachment: 2803.patch added

comment:1 Changed 11 years ago by Martin Kou

Keywords: Review? added

comment:2 Changed 11 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

The code looks good, but can you please provide a patch for trunk?

Changed 11 years ago by Martin Kou

Attachment: 2803_2.patch added

comment:3 Changed 11 years ago by Martin Kou

Keywords: Review? added; Review- removed

comment:4 Changed 11 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:5 Changed 11 years ago by Martin Kou

Resolution: fixed
Status: newclosed

Fixed with [3044].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy