Opened 10 years ago

Closed 10 years ago

#2804 closed Bug (fixed)

V3: Review the insertHtml and insertElement implementation

Reported by: Frederico Caldeira Knabben Owned by: Frederico Caldeira Knabben
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

The current implementation of insertHtml and insertElement could be simplified. Also, it includes the insertion logic inside the editingblock plugin, which is wrong.

Attachments (1)

2804.patch (5.5 KB) - added by Frederico Caldeira Knabben 10 years ago.

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Frederico Caldeira Knabben

Attachment: 2804.patch added

comment:1 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review? added
Status: newassigned

This patch simplifies the insertHtml and insertElement implementation. The code has been moved from editingblock to wysiwygarea. The code in wysiwygarea has been reviewed also.

comment:2 Changed 10 years ago by Martin Kou

Keywords: Review- added; Review? removed

Line 76 and 78 of wysiwygarea plugin is giving out JavaScript errors.

comment:3 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review- removed
Resolution: fixed
Status: assignedclosed

Ok... I've fixed those two lines and committed it with [2979], following Martin's skype confirmation.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy