Opened 16 years ago
Closed 16 years ago
#2804 closed Bug (fixed)
V3: Review the insertHtml and insertElement implementation
| Reported by: | Frederico Caldeira Knabben | Owned by: | Frederico Caldeira Knabben |
|---|---|---|---|
| Priority: | Must have (possibly next milestone) | Milestone: | CKEditor 3.0 |
| Component: | General | Version: | |
| Keywords: | Confirmed Review+ | Cc: |
Description
The current implementation of insertHtml and insertElement could be simplified. Also, it includes the insertion logic inside the editingblock plugin, which is wrong.
Attachments (1)
Change History (4)
Changed 16 years ago by
| Attachment: | 2804.patch added |
|---|
comment:1 Changed 16 years ago by
| Keywords: | Review? added |
|---|---|
| Status: | new → assigned |
comment:2 Changed 16 years ago by
| Keywords: | Review- added; Review? removed |
|---|
Line 76 and 78 of wysiwygarea plugin is giving out JavaScript errors.
comment:3 Changed 16 years ago by
| Keywords: | Review+ added; Review- removed |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Ok... I've fixed those two lines and committed it with [2979], following Martin's skype confirmation.
Note: See
TracTickets for help on using
tickets.
This patch simplifies the insertHtml and insertElement implementation. The code has been moved from editingblock to wysiwygarea. The code in wysiwygarea has been reviewed also.