Opened 9 years ago

Closed 6 years ago

#2813 closed Bug (invalid)

Deleting a row does not correct the rowspan of merged cells

Reported by: Koen Willems Owned by: Martin Kou
Priority: Normal Milestone:
Component: Core : Tables Version: FCKeditor 2.6.4
Keywords: HasPatch? Cc: kwillems@…

Description

Take a table like this:

<table title="tabel" cellspacing="0" cellpadding="0" summary="table">
    <thead>
        <tr>
            <th scope="col">1</th>
            <th scope="col">2</th>
        </tr>
    </thead>
    <tbody>
        <tr>
            <td>a</td>
            <td rowspan="3">b</td>
        </tr>
        <tr>
            <td>c</td>
        </tr>
        <tr>
            <td>d</td>
        </tr>
    </tbody>
</table>

Now, put the cursor in cell a, right click and remove that row. We see that cell b disappears. Or go to cell b and remove that row: cell b is deleted and cells c and d are left over.

Attachments (5)

2813.patch (2.6 KB) - added by Koen Willems 9 years ago.
2813_2.patch (2.5 KB) - added by Koen Willems 9 years ago.
2813_3.patch (6.5 KB) - added by Martin Kou 8 years ago.
2813_4.patch (6.6 KB) - added by Martin Kou 8 years ago.
2813_5.patch (6.6 KB) - added by Martin Kou 8 years ago.

Download all attachments as: .zip

Change History (16)

Changed 9 years ago by Koen Willems

Attachment: 2813.patch added

comment:1 Changed 9 years ago by Koen Willems

And I added a patch.

Changed 9 years ago by Koen Willems

Attachment: 2813_2.patch added

comment:2 Changed 9 years ago by Koen Willems

Made a little improvement; there was an unneccesary check in the previous patch.

comment:3 Changed 9 years ago by Koen Willems

Cc: kwillems@… added
Milestone: FCKeditor 2.6.5
Version: FCKeditor 2.6.4

comment:4 Changed 8 years ago by Martin Kou

Keywords: HasPatch added
Owner: set to Martin Kou
Status: newassigned

Changed 8 years ago by Martin Kou

Attachment: 2813_3.patch added

comment:5 Changed 8 years ago by Martin Kou

Keywords: Review? added

comment:6 Changed 8 years ago by Martin Kou

Keywords: Review- added; Review? removed

The patch is breaking the merge command when 2x2 cells are selected in the default table.

comment:7 Changed 8 years ago by Martin Kou

Keywords: Review? added; Review- removed

Changed 8 years ago by Martin Kou

Attachment: 2813_4.patch added

Changed 8 years ago by Martin Kou

Attachment: 2813_5.patch added

comment:8 Changed 8 years ago by Martin Kou

Found a typo in 2813_4.patch while working on #2859 - posted new patch which fixes it.

comment:9 Changed 8 years ago by Frederico Caldeira Knabben

Milestone: FCKeditor 2.6.5

There are too many changes being proposed to the code. As the 2.6.5 is mainly concerned about compatibility, it's better to avoid the risk of braking this.

We may include these changes in a future version, probably on CKEditor instead.

comment:10 Changed 7 years ago by Wiktor Walc

Component: GeneralCore : Tables

comment:11 Changed 6 years ago by Jakub Ś

Resolution: invalid
Status: reviewclosed

FCKeditor was retired and is no longer supported. All active development was moved to its successor, CKEditor 3.x, that is a fully mature and far superior product. We recommend you upgrade as soon as possible since this issue is no longer a problem in current code base.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy