Opened 10 years ago

Closed 10 years ago

#2816 closed Bug (duplicate)

[IE] Refactor selection save/restore logic to work with focus state

Reported by: Garry Yao Owned by: Martin Kou
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (FCKeditor) - Retired
Keywords: IE Review- Cc:

Description (last modified by Garry Yao)

Restore selection doesn't work for blued editor document. since editor is initially blured, direct dialog open will suffer from it.

Procedures

  1. Open replacebyclass.html in IE6.
  2. Triple click to select the "CKEditor Sample" title in the page.
  3. Open any dialog - link, image, table, etc.
  4. You get a JavaScript error if the dialog tries to restore the selection.
  5. Close the dialog by clicking cancel.
  6. You get another JavaScript error.

Attachments (4)

2816.patch (545 bytes) - added by Garry Yao 10 years ago.
2816_2.patch (22.4 KB) - added by Garry Yao 10 years ago.
2816_3.patch (20.6 KB) - added by Garry Yao 10 years ago.
Revise coding styles
2816_4.patch (20.5 KB) - added by Garry Yao 10 years ago.
Fix leading spaces

Download all attachments as: .zip

Change History (12)

Changed 10 years ago by Garry Yao

Attachment: 2816.patch added

comment:1 Changed 10 years ago by Garry Yao

Description: modified (diff)
Keywords: HasPatch added

It's a quick patch just make no error thrown, pending for more confirmation.

comment:2 Changed 10 years ago by Garry Yao

Related v2 bugs including: #2376, #2616, #1801, #2495

Changed 10 years ago by Garry Yao

Attachment: 2816_2.patch added

comment:3 Changed 10 years ago by Garry Yao

Keywords: Review? added; HasPatch removed

Proposed patch for properly restore selection for all commands.

Changed 10 years ago by Garry Yao

Attachment: 2816_3.patch added

Revise coding styles

Changed 10 years ago by Garry Yao

Attachment: 2816_4.patch added

Fix leading spaces

comment:4 Changed 10 years ago by Garry Yao

Description: modified (diff)
Summary: [IE] Failed to restore collapsed selection from editor blured[IE] Failed to restore selection on dialog open when editor blured

comment:5 Changed 10 years ago by Garry Yao

Keywords: Review- added; Review? removed
Summary: [IE] Failed to restore selection on dialog open when editor blured[IE] Refactor selection save/restore logic to work with focus state

The last patch delegate all the save/restore logic only when dialog show/hide which is wrong, certain plugins still require manual save/restore API. A new patch would be provided with the following problem addressed:

  • Automatically save editor selection(selected ranges) when document blurred;
  • Preserve manually save/restore API for flexibility in dialog commands;
  • Mimic multiple selection with the same highlight style used in find/replace marking;

comment:6 Changed 10 years ago by Garry Yao

Owner: set to Martin Kou

As talked on Skype, Martin will take over this patch.

comment:7 Changed 10 years ago by Martin Kou

Status: newassigned

Garry has explained to me the changes and rationales behind his proposals, and asked me to take over the ticket due to the complexities involved.

comment:8 Changed 10 years ago by Garry Yao

Resolution: duplicate
Status: assignedclosed

It's going to be fixed by #3001.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy