Changes between Initial Version and Version 5 of Ticket #2835


Ignore:
Timestamp:
Feb 3, 2009, 9:16:44 AM (12 years ago)
Author:
Frederico Caldeira Knabben
Comment:

There are a few problems with this patch:

  • The "selection" plugin makes references to stuff introduced by the "dialog" and "editingblock" plugins. The "selection" plugin is a kind of 'basic' feature for the entire core, we should not have those kinds of references.
  • Creating an event that fires "before" the dialog close logic will still not fix all commands execution. Actually, it would work on dialog based commands only and, as it's executed before the dialog logic, the selection could still be wrong after the dialog logic is applied.

There are other ways for this fix. I'll be coming with a new patch for it.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2835

    • Property Owner set to Frederico Caldeira Knabben
    • Property Keywords Confirmed Review- added
    • Property Summary changed from V3: New page plugin - setData() bug. to plugin:newpage failed to refresh elementpath
  • Ticket #2835 – Description

    initial v5  
    11Steps to reproduce:
    2 -Open sample.html?sample=replacebyclass
    3 -Out cursor in "sample text". [B] is selected. Path: body-p-strong.
    4 -Click NewPage button
    5 -Editor is empty but [B] is still active and path is the same.
     2
     3 - Open sample.html?sample=replacebyclass
     4 - Out cursor in "sample text". [B] is selected. Path: body-p-strong.
     5 - Click NewPage button
     6 - Editor is empty but [B] is still active and path is the same.
© 2003 – 2020 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy