Opened 15 years ago
Last modified 15 years ago
#2835 closed Bug
plugin:newpage failed to refresh elementpath — at Version 5
Reported by: | Artur Formella | Owned by: | Frederico Caldeira Knabben |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.0 |
Component: | General | Version: | SVN (FCKeditor) - Retired |
Keywords: | Confirmed Review+ | Cc: |
Description (last modified by )
Steps to reproduce:
- Open sample.html?sample=replacebyclass
- Out cursor in "sample text". [B] is selected. Path: body-p-strong.
- Click NewPage button
- Editor is empty but [B] is still active and path is the same.
Change History (7)
comment:1 Changed 15 years ago by
comment:2 Changed 15 years ago by
Owner: | set to Garry Yao |
---|---|
Status: | new → assigned |
Summary: | V3: New page plugin - setData() bug. → plugin:newpage failed to refresh elementpath |
comment:3 Changed 15 years ago by
Keywords: | Confirmed added |
---|
Changed 15 years ago by
Attachment: | 2835.patch added |
---|
comment:4 Changed 15 years ago by
Keywords: | Review? added |
---|
The patch also fix for failed to refresh elementpath after every command's execution.
comment:5 Changed 15 years ago by
Description: | modified (diff) |
---|---|
Keywords: | Review- added; Review? removed |
Owner: | changed from Garry Yao to Frederico Caldeira Knabben |
Status: | assigned → new |
There are a few problems with this patch:
- The "selection" plugin makes references to stuff introduced by the "dialog" and "editingblock" plugins. The "selection" plugin is a kind of 'basic' feature for the entire core, we should not have those kinds of references.
- Creating an event that fires "before" the dialog close logic will still not fix all commands execution. Actually, it would work on dialog based commands only and, as it's executed before the dialog logic, the selection could still be wrong after the dialog logic is applied.
There are other ways for this fix. I'll be coming with a new patch for it.
Changed 15 years ago by
Attachment: | 2835_2.patch added |
---|
I mean: -Put cursor in "sample text".