Opened 16 years ago
Closed 16 years ago
#2836 closed Bug (fixed)
V3: Toolbar commands doesn't get disabled in 'source' mode
Reported by: | Artur Formella | Owned by: | Frederico Caldeira Knabben |
---|---|---|---|
Priority: | Must have (possibly next milestone) | Milestone: | CKEditor 3.0 |
Component: | General | Version: | SVN (FCKeditor) - Retired |
Keywords: | Confirmed Review+ | Cc: |
Description
Steps to reproduce: -Open sample.html?sample=replacebyclass -Click Source -Click Smile button
Result: JS Error and cancel button doesn't work.
this.document is null http://localhost/edytor/CKEditor/trunk/_source/plugins/selection/plugin.js Line 219
Attachments (6)
Change History (22)
comment:1 Changed 16 years ago by
Summary: | V3: Source mode and dialogs → V3: Toolbar commands doesn't get disabled in 'source' mode |
---|
comment:2 Changed 16 years ago by
Keywords: | Confirmed added |
---|
comment:3 Changed 16 years ago by
comment:4 Changed 16 years ago by
Keywords: | Review? added |
---|
Changed 16 years ago by
Attachment: | 2836.patch added |
---|
comment:5 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
Please also update the latest plugin with 'activeInModes'.
comment:6 Changed 16 years ago by
Keywords: | Review- added; Review+ removed |
---|
The changes in _source/plugins/toolbar/plugin.js are not related.
Changed 16 years ago by
Attachment: | 2836_2.patch added |
---|
comment:7 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|---|
Owner: | set to Artur Formella |
Status: | new → assigned |
comment:8 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
I forgot about flash plugin...
Changed 16 years ago by
Attachment: | 2836_3.patch added |
---|
comment:9 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
Improved WSC and flash plugin.
I open new tickets for richcombo and panelbutton
comment:10 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|---|
Owner: | changed from Artur Formella to Frederico Caldeira Knabben |
Status: | assigned → new |
Your approach is not wrong. As most of the commands are available in WYSIWYG only, we could simplify it a bit by assuming a default values for the "activeInModes" property (which I would prefer calling simply "modes", for shortnesses).
It also misses support for the combos and the panel buttons (#3060). It means that we need also changes to the skin files.
As most of these things have been coded by me recently, and due to the urgency we have for this ticket, I'm taking it over. I'll come with a patch as soon as #3021 gets committed, because it will bring lots of changes to the skins CSS and I would prefer to work on it after that.
Changed 16 years ago by
Attachment: | 2836_4.patch added |
---|
comment:11 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|---|
Status: | new → assigned |
Changed 16 years ago by
Attachment: | 2836_5.patch added |
---|
comment:13 follow-up: 14 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
- RichCombo marked list item state is not reset on mode switch, reproduce by :
- Open the replace by code example page;
- Open a combo and select a item;
- Switch to 'source' mode and then switch back;
- Actual Result: Still marked selection result from previous.
- BOM in front of file _source\plugins\richcombo\plugin.js
- Trunk content inside _source\plugins\undo\plugin.js has none related changes to undo system, which should be handled by other tickets.
- It's better if the incoming patch could take care of the new plug-ins, save and maximize.
Changed 16 years ago by
Attachment: | 2836_6.patch added |
---|
comment:14 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
Replying to garry.yao:
- RichCombo marked list item state is not reset on mode switch, reproduce by :
- Open the replace by code example page;
- Open a combo and select a item;
- Switch to 'source' mode and then switch back;
- Actual Result: Still marked selection result from previous.
This one is not related to this ticket and should not block it. Please open a new ticket for it.
- BOM in front of file _source\plugins\richcombo\plugin.js
Again, this is not to be checked. It's not a problem to have the BOM there.
- Trunk content inside _source\plugins\undo\plugin.js has none related changes to undo system, which should be handled by other tickets.
It's definitely related, as the undo/redo buttons don't get disabled in source mode without it.
- It's better if the incoming patch could take care of the new plug-ins, save and maximize.
I've included the "save" plugin in this new patch. The "maximize" plugin is not yet in the trunk.
comment:15 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
#2968 has been marked as DUP