V3: Toolbar commands doesn't get disabled in 'source' mode

[Artur Formella]

Steps to reproduce: -Open sample.html?sample=replacebyclass -Click Source -Click Smile button

Result: JS Error and cancel button doesn't work.

this.document is null
http://localhost/edytor/CKEditor/trunk/_source/plugins/selection/plugin.js
Line 219

[Frederico Caldeira Knabben]

#2968 has been marked as DUP

[Garry Yao]

Please also update the latest plugin with 'activeInModes'.

[Frederico Caldeira Knabben]

The changes in _source/plugins/toolbar/plugin.js are not related.

[Artur Formella]

I forgot about flash plugin...

[Artur Formella]

Improved WSC and flash plugin.

I open new tickets for richcombo and panelbutton

[Frederico Caldeira Knabben]

Your approach is not wrong. As most of the commands are available in WYSIWYG only, we could simplify it a bit by assuming a default values for the "activeInModes" property (which I would prefer calling simply "modes", for shortnesses).

It also misses support for the combos and the panel buttons (#3060). It means that we need also changes to the skin files.

As most of these things have been coded by me recently, and due to the urgency we have for this ticket, I'm taking it over. I'll come with a patch as soon as #3021 gets committed, because it will bring lots of changes to the skins CSS and I would prefer to work on it after that.

[Frederico Caldeira Knabben]

New patch, without the unrelated change to sample.html.

[Garry Yao]

1. RichCombo marked list item state is not reset on mode switch, reproduce by :
   1. Open the replace by code example page;
   2. Open a combo and select a item;
   3. Switch to 'source' mode and then switch back;
      • Actual Result: Still marked selection result from previous.
2. BOM in front of file _source\plugins\richcombo\plugin.js
3. Trunk content inside _source\plugins\undo\plugin.js has none related changes to undo system, which should be handled by other tickets.
4. It's better if the incoming patch could take care of the new plug-ins, save and maximize.

[Frederico Caldeira Knabben]

Replying to garry.yao:

1. RichCombo marked list item state is not reset on mode switch, reproduce by :
   1. Open the replace by code example page;
   2. Open a combo and select a item;
   3. Switch to 'source' mode and then switch back;
      • Actual Result: Still marked selection result from previous.

This one is not related to this ticket and should not block it. Please open a new ticket for it.

1. BOM in front of file _source\plugins\richcombo\plugin.js

Again, this is not to be checked. It's not a problem to have the BOM there.

1. Trunk content inside _source\plugins\undo\plugin.js has none related changes to undo system, which should be handled by other tickets.

It's definitely related, as the undo/redo buttons don't get disabled in source mode without it.

1. It's better if the incoming patch could take care of the new plug-ins, save and maximize.

I've included the "save" plugin in this new patch. The "maximize" plugin is not yet in the trunk.

[Frederico Caldeira Knabben]

Fixed with [3227].