Opened 16 years ago
Closed 16 years ago
#3021 closed Bug (fixed)
Toolbar layout is messed up in IE6 quirks mode
Reported by: | Martin Kou | Owned by: | Frederico Caldeira Knabben |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.0 |
Component: | UI : Toolbar | Version: | SVN (FCKeditor) - Retired |
Keywords: | Confirmed Oracle IE Review+ | Cc: | Senthil |
Description
To reproduce:
- Delete the <!DOCTYPE> line in sample.html.
- Open replacebyclass.html in IE6.
- The toolbar is messed up.
Attachments (2)
Change History (8)
comment:1 Changed 16 years ago by
Cc: | Senthil added |
---|---|
Keywords: | Confirmed Oracle IE added |
Owner: | set to Frederico Caldeira Knabben |
Status: | new → assigned |
Changed 16 years ago by
Attachment: | 3021.patch added |
---|
comment:2 Changed 16 years ago by
Keywords: | Review? added |
---|
The proposed patch brings important changes to the DOM structure we use for UI elements:
- All instances of "multiple classes selectors" have been removed from the CSS for toolbar elements.
- Produces a deeper <span> hierarchy for UI elements, so we can properly select them in the CSS.
- Introduced special class names for IE6 and IE+Quirks, so we can properly hack them into the CSS.
The patch contains a full CSS review, except for the dialog stuff.
comment:3 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
comment:4 follow-up: 5 Changed 16 years ago by
Still have a lot of multiple classes in sight with the test case, not sure if they need to be refacted also.
comment:5 Changed 16 years ago by
Replying to garry.yao:
Still have a lot of multiple classes in sight with the test case, not sure if they need to be refacted also.
The problem is not having multiple classes in the elements, but using the multiple classes selector in the CSS. This test is not needed.
We are using "multiple classes selectors" in our UI CSS files. This is quite powerful as it makes the DOM structure much simpler and the CSS development much more modular.
Problem: IE has no support for this kinds of selectors when in quirks mode.