Opened 11 years ago

Closed 11 years ago

#3020 closed Bug (fixed)

plugin:selection incomplete selectable element definition

Reported by: Garry Yao Owned by: Garry Yao
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.0
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Confirmed Review+ Cc:

Description

The current selectable elements( elements which could be retrieved from CKEDITOR.dom.selection.getSelectedElement) below is lacking of other control types like a,input,form.

var styleObjectElements = { img:1,hr:1,li:1,table:1,tr:1,td:1,embed:1,object:1,ol:1,ul:1 };

Attachments (3)

test-selection.patch (7.5 KB) - added by Garry Yao 11 years ago.
test-selection.2.patch (3.4 KB) - added by Garry Yao 11 years ago.
Updated Functiona Test Case
3020.patch (606 bytes) - added by Garry Yao 11 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 11 years ago by Garry Yao

Tested with Plugin:selection:test_selectElement.

Changed 11 years ago by Garry Yao

Attachment: test-selection.patch added

comment:2 Changed 11 years ago by Frederico Caldeira Knabben

Keywords: Confirmed added
Priority: NormalHigh

I'm not able to apply the patch, but I confirm those elements should be part of that list.

The list of missing items that come to my mind now are: a, input, form, select, textarea, button, fieldset, th, thead and tfoot.

comment:3 Changed 11 years ago by Garry Yao

Owner: set to Garry Yao
Status: newassigned

Changed 11 years ago by Garry Yao

Attachment: test-selection.2.patch added

Updated Functiona Test Case

Changed 11 years ago by Garry Yao

Attachment: 3020.patch added

comment:4 Changed 11 years ago by Garry Yao

Keywords: Review? added

comment:5 Changed 11 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:6 Changed 11 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [3268].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy