Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#2837 closed Bug (fixed)

Basicstyle plugin bug

Reported by: Artur Formella Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (FCKeditor) - Retired
Keywords: IE Confirmed Review+ Cc:

Description

Steps to reproduce:

-Open trunk/_samples/sample.html?sample=replacebyclass in IE

-Select "some" and click Bold.

-Click Source.

-Back to WYSIWYG.

-Select "using" and click Bold.

Result: JS error. Source code:

<p _cke_expando="65">
	This is <strong _cke_expando="70">some sample text</strong>. You are <span _cke_expando="78" _fck_bookmark="1" style="DISPLAY: none">&nbsp;</span>using <span _cke_expando="78" _fck_bookmark="1" style="DISPLAY: none">&nbsp;</span><a _cke_expando="79" href="http://www.fckeditor.net/">FCKeditor</a>.</p>

In FF works fine.

Attachments (2)

2837.patch (1.2 KB) - added by Garry Yao 9 years ago.
2837_2.patch (634 bytes) - added by Garry Yao 9 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 9 years ago by Martin Kou

Keywords: Confirmed added

comment:2 Changed 9 years ago by Artur Formella

In Opera 9.63 selected text disappears.

comment:3 Changed 9 years ago by Garry Yao

Owner: set to Garry Yao
Status: newassigned

Changed 9 years ago by Garry Yao

Attachment: 2837.patch added

comment:4 Changed 9 years ago by Garry Yao

Keywords: Review? added

Disable caching style element which cause error when content dom is reloaded, it shouldn't have great impact on PF.

comment:5 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed
  • If the patch is proposing not using anymore a cache, so style._.element is to be removed. There is no sense having it anymore.
  • Why line 549 has been moved to 541 (before the if)?
  • (Detail) A blank line remained at line 532.

Changed 9 years ago by Garry Yao

Attachment: 2837_2.patch added

comment:6 Changed 9 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:7 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:8 Changed 9 years ago by Garry Yao

Fixed with [3054].

comment:9 Changed 9 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: assignedclosed

The commit should match the patch, which is not true in this case. An unexpected ignore rule has been added to the root. We should avoid such things.

comment:10 Changed 9 years ago by Garry Yao

Rollback the none-related change with [3075].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy