plugin:newpage failed to refresh elementpath

[Artur Formella]

Steps to reproduce:

• Open sample.html?sample=replacebyclass
• Out cursor in "sample text". [B] is selected. Path: body-p-strong.
• Click NewPage button
• Editor is empty but [B] is still active and path is the same.

[Artur Formella]

I mean: -Put cursor in "sample text".

[Garry Yao]

The patch also fix for failed to refresh elementpath after every command's execution.

[Frederico Caldeira Knabben]

There are a few problems with this patch:

• The "selection" plugin makes references to stuff introduced by the "dialog" and "editingblock" plugins. The "selection" plugin is a kind of 'basic' feature for the entire core, we should not have those kinds of references.

• Creating an event that fires "before" the dialog close logic will still not fix all commands execution. Actually, it would work on dialog based commands only and, as it's executed before the dialog logic, the selection could still be wrong after the dialog logic is applied.

There are other ways for this fix. I'll be coming with a new patch for it.

[Frederico Caldeira Knabben]

One of the problems was that the New Page command is not setting the editor focus when executed. The proposed patch fixes it.

Then, we where missing a way to actively indicated a selection change. The patch introduces it, making the focus() call always execute this change notification.

[Martin Kou]

I did something similar to #2864's patch as well, but this one's simpler and faster.

[Frederico Caldeira Knabben]

Fixed with [3053]. Click here for more info about our SVN system.