Opened 10 years ago

Closed 10 years ago

#2835 closed Bug (fixed)

plugin:newpage failed to refresh elementpath

Reported by: Artur Formella Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Confirmed Review+ Cc:

Description (last modified by Frederico Caldeira Knabben)

Steps to reproduce:

  • Open sample.html?sample=replacebyclass
  • Out cursor in "sample text". [B] is selected. Path: body-p-strong.
  • Click NewPage button
  • Editor is empty but [B] is still active and path is the same.

Attachments (2)

2835.patch (1.3 KB) - added by Garry Yao 10 years ago.
2835_2.patch (1.2 KB) - added by Frederico Caldeira Knabben 10 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 10 years ago by Artur Formella

I mean: -Put cursor in "sample text".

comment:2 Changed 10 years ago by Garry Yao

Owner: set to Garry Yao
Status: newassigned
Summary: V3: New page plugin - setData() bug.plugin:newpage failed to refresh elementpath

comment:3 Changed 10 years ago by Garry Yao

Keywords: Confirmed added

Changed 10 years ago by Garry Yao

Attachment: 2835.patch added

comment:4 Changed 10 years ago by Garry Yao

Keywords: Review? added

The patch also fix for failed to refresh elementpath after every command's execution.

comment:5 Changed 10 years ago by Frederico Caldeira Knabben

Description: modified (diff)
Keywords: Review- added; Review? removed
Owner: changed from Garry Yao to Frederico Caldeira Knabben
Status: assignednew

There are a few problems with this patch:

  • The "selection" plugin makes references to stuff introduced by the "dialog" and "editingblock" plugins. The "selection" plugin is a kind of 'basic' feature for the entire core, we should not have those kinds of references.
  • Creating an event that fires "before" the dialog close logic will still not fix all commands execution. Actually, it would work on dialog based commands only and, as it's executed before the dialog logic, the selection could still be wrong after the dialog logic is applied.

There are other ways for this fix. I'll be coming with a new patch for it.

Changed 10 years ago by Frederico Caldeira Knabben

Attachment: 2835_2.patch added

comment:6 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review? added; Review- removed
Status: newassigned

One of the problems was that the New Page command is not setting the editor focus when executed. The proposed patch fixes it.

Then, we where missing a way to actively indicated a selection change. The patch introduces it, making the focus() call always execute this change notification.

comment:7 Changed 10 years ago by Martin Kou

Keywords: Review+ added; Review? removed

I did something similar to #2864's patch as well, but this one's simpler and faster.

comment:8 Changed 10 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: assignedclosed

Fixed with [3053]. Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy