Opened 16 years ago
Closed 16 years ago
#2864 closed Task (fixed)
Implement the insert and remove numbered list and bullet list commands.
Reported by: | Martin Kou | Owned by: | Martin Kou |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.0 |
Component: | Core : Lists | Version: | SVN (FCKeditor) - Retired |
Keywords: | Review+ | Cc: |
Description
Need to implement the list commands and add them to the toolbar.
Attachments (3)
Change History (13)
comment:1 Changed 16 years ago by
Status: | new → assigned |
---|
Changed 16 years ago by
Attachment: | 2864.patch added |
---|
comment:2 Changed 16 years ago by
Keywords: | Review? added |
---|
comment:3 Changed 16 years ago by
Simplified two things:
- Eliminated the duplicate code in CKEDITOR.dom.range::getCommonAncestor().
- Changed the selectionSet event in CKEDITOR.dom.selection to a simpler onSelectionSet function hook.
Selection after list removal or list type change is wrong now because the selection bookmarks are not serialize-able at this moment. Garry is trying to fix that issue in #2763 so I'll leave it as-is for now.
Changed 16 years ago by
Attachment: | 2864_2.patch added |
---|
comment:4 Changed 16 years ago by
Also note that part of the logic in #2865 depends on the list plugin, since list indenting uses the logic in the list plugin.
Changed 16 years ago by
Attachment: | 2864_3.patch added |
---|
comment:6 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
comment:8 Changed 16 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
I found in FF source codes was changed after the following steps, markers nodes were left inside.
- Apply numbered/bullet list style
- Remove numbered/bullet list style
- Check codes in source mode
comment:9 Changed 16 years ago by
That's exactly due to the serialize-able selection problem that you're trying to fix in #2763.
What's happening right now is..
- Bookmarks are saved before changing lists.
- The original list is removed with the non-serialize-able bookmark nodes.
- The original list is cloned with the bookmark nodes, and modified to become the new list.
- The new list is added to the document with the cloned bookmark nodes.
- The selection plugin tries to restore selection to the removed bookmark nodes, leaving the cloned bookmark nodes in the document.
So this bug is not the list plugin's fault, but rather the selection system's fault.
comment:10 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Sorry, I should have noticed that, it seems the serialize-able bookmark works for this case since you're relying on Node::cloneNode which will reserve id attribute.
The patch must be applied in conjunction with the patch to #2871.
Things fixed or modified in addition to adding the list command: