Opened 11 years ago

Closed 11 years ago

#2863 closed Task (fixed)

Move Print plugin to trunk.

Reported by: Artur Formella Owned by: Artur Formella
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Review+ Cc:

Description

We need to move the Print plugin to trunk.

Attachments (3)

2863.patch (2.1 KB) - added by Artur Formella 11 years ago.
2863_2.patch (2.2 KB) - added by Artur Formella 11 years ago.
2863_3.patch (2.8 KB) - added by Artur Formella 11 years ago.

Download all attachments as: .zip

Change History (11)

Changed 11 years ago by Artur Formella

Attachment: 2863.patch added

comment:1 Changed 11 years ago by Artur Formella

Keywords: Review? added

comment:2 Changed 11 years ago by Frederico Caldeira Knabben

Component: UI : ToolbarGeneral
Keywords: Review- added; Review? removed
Priority: HighNormal
  • The plugin is registering an invalid dialog at line 17.
  • It prints correctly with Firefox and Safari only. With IE and Opera, it prints the outer page. In IE, execCommand should be used.
  • The plugin configuration entries should be alphabetically ordered.
  • The file description: "Print CKE Document". What's CKE? What about "Print plugin" only instead?

Changed 11 years ago by Artur Formella

Attachment: 2863_2.patch added

comment:3 Changed 11 years ago by Artur Formella

How to print IFRAME content in Opera?

I was thinking about setting it disabled in opera.

comment:4 Changed 11 years ago by Artur Formella

Keywords: Review? added; Review- removed

comment:5 in reply to:  3 Changed 11 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

Replying to arczi:

I was thinking about setting it disabled in opera.

Yes, that's the way to go. This is the behavior we have with FCKeditor today. More explanation can be found at #1180.

Changed 11 years ago by Artur Formella

Attachment: 2863_3.patch added

comment:6 Changed 11 years ago by Artur Formella

Keywords: Review? added; Review- removed

I changed addCommand a bit and now it is easier to change the state.

comment:7 Changed 11 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:8 Changed 11 years ago by Artur Formella

Resolution: fixed
Status: newclosed

Fixed with [3073]

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy