Opened 16 years ago
Closed 16 years ago
#2871 closed Task (fixed)
Implement DOM range iterator.
Reported by: | Martin Kou | Owned by: | Martin Kou |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.0 |
Component: | General | Version: | SVN (FCKeditor) - Retired |
Keywords: | Review+ | Cc: |
Attachments (4)
Change History (11)
comment:1 Changed 16 years ago by
Keywords: | Review? added |
---|---|
Status: | new → assigned |
Changed 16 years ago by
Attachment: | 2871.patch added |
---|
Changed 16 years ago by
Attachment: | 2871_2.patch added |
---|
comment:2 Changed 16 years ago by
Fixed a bug which causes JavaScript errors in CKEDITOR.dom.node::rtrim().
Changed 16 years ago by
Attachment: | 2871_3.patch added |
---|
comment:3 Changed 16 years ago by
comment:4 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
- The "domiterator" is the kind of plugin that don't have to go inside the plugins configuration. It's loaded only if we have other plugins that depend on it.
- As I could note, things have been copied from V2 as is, with no adaptation to V3. It means we'll have to work more on this code later.
- There was a reason for having getFirst and getLast inside element, and not on node. Actually, they are not useful outside the element scope. For example, "textNode.getFirst()" means nothing. I don't care about the W3C DOM here, as our intention is not to implement it. We have a custom implementation that can be clearer, and so we should avoid such DOM generalities. If part of our code is supposed to do "textNode.getFirst()", then our code must be fixed, as it only impacts on performance, as we know it'll never return a node. Anything that's element specific must go inside the element class only.
Changed 16 years ago by
Attachment: | 2871_4.patch added |
---|
comment:5 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:6 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
This patch also adds trim(), ltrim() and rtrim() under CKEDITOR.dom.node. Also it moved getFirst() and getLast() to CKEDITOR.dom.node, as those functions may be used outside of elements.