"CKEDITOR is not defined" on page reload when editor focused.

[Garry Yao]

This bug is found to be due to reload the page with focus on wysiwyg mode, cause a javascript error as titled in FF.

[Frederico Caldeira Knabben]

The correct way to check for a global variable existence is by using the "window" object, not "document". Don't know how it worked for you, but theoretically it shouldn't.

Please also add a comment including this ticket number, so we can understand why we are doing that in the future.

[Frederico Caldeira Knabben]

The first patch was much better than this new one. You should have only changed "document" to "window", as I've described. I can't understand the changes on "editor_basic.js" also.

I'll be attaching a new patch for it, as this one is quite an annoying bug.

[Garry Yao]

It's actually a very edge bug for FF, the native event which caused the error is found to be keyup, which only happened when reloading page with key shortcut like F5 and Ctrl-R, it could be identified with the following modification to the same patching position as in 2923_3.patch.

			if ( typeof CKEDITOR != 'undefined' ) 
				domObject.fire( eventName, new CKEDITOR.dom.event( domEvent ) );
			else 
				throw new Error( domEvent.type );

So at the point of this error, the whole JavaScript global context which is window doesn't present at all, we need to make the sniffer happened at JavaScript Core level instead of the host environment perhaps.

[Frederico Caldeira Knabben]

Fixed with [3211].