Opened 10 years ago

Closed 10 years ago

#2959 closed Bug (fixed)

plugin:editingblock reload initial data on empty content

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Confirmed Review+ Cc:

Description

Procedures

  1. Open the replace by code example page;
  2. Switch to source mode, and delete all content;
  3. Switch back to wysiwyg mode, check the document:
  • Expected Result : The content is empty.
  • Actual Result : The initial content data is there:
    <p>
    	This is some <strong>sample text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</p>
    

Attachments (1)

2959.patch (443 bytes) - added by Garry Yao 10 years ago.

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Garry Yao

Attachment: 2959.patch added

comment:1 Changed 10 years ago by Garry Yao

Keywords: Review? added
Status: newassigned

Yet another falsely value issue.

comment:2 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

It's a matter of coding style. Whenever possible, we should code it just like we would usually say it in spoken language: "if the type of data is different from string". So, you end up with if ( typeof data != 'string' ). That's the way you'll find it in our code.

If possible, just fix it when committing.

comment:3 Changed 10 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [3101].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy