Opened 11 years ago

Last modified 8 years ago

#2976 review_failed Bug

plugin:basicstyle remove style at collapsed selection

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone:
Component: Core : Styles Version: 3.0 Beta 2
Keywords: Cc:

Description

Description

Current inline style system doesn't handle the case when selection is collapsed inside styled element correctly. A MS-Word mimics behavior should be provided to actually allow users to type in the middle with the style canceled.

Procedures

  1. Open the replace by code example page in IE6;
  2. Make selection as below:
    <p>This is some <strong>sam^ple text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</p>
    
  3. Click bold command to cancel the bold style
  • Actual Result :
    <p>This is some sample text. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</p>
    
  • Expected Result: The document remain unchanged, but when the user begin to type from this selection point, text should in unbold style.
    <p>This is some <strong>sam^ple text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</p>
    
  • E.g after user type 'xxx' , document should result in :
    <p>This is some <strong>sam</strong>xxx<strong>ple text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</p>
    

Attachments (2)

2976.patch (7.1 KB) - added by Garry Yao 11 years ago.
2976.2.patch (6.7 KB) - added by Josh Nisly 11 years ago.
Resyncing to current SVN HEAD

Download all attachments as: .zip

Change History (13)

comment:1 Changed 11 years ago by Frederico Caldeira Knabben

Component: GeneralCore : Styles
Milestone: CKEditor 3.0CKEditor 3.x

comment:2 Changed 11 years ago by Garry Yao

Keywords: Confirmed added
Milestone: CKEditor 3.xCKEditor 3.0
Type: TaskBug

See #3309 for more usability issue related to this bug.

comment:3 Changed 11 years ago by Garry Yao

Owner: set to Garry Yao
Status: newassigned

Changed 11 years ago by Garry Yao

Attachment: 2976.patch added

comment:4 Changed 11 years ago by Garry Yao

Keywords: Review? added

comment:5 Changed 11 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.0CKEditor 3.x

Changed 11 years ago by Josh Nisly

Attachment: 2976.2.patch added

Resyncing to current SVN HEAD

comment:6 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Version: SVN (FCKeditor)CKEditor 3.0 Beta 2

comment:7 Changed 9 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.x

Milestone CKEditor 3.x deleted

comment:8 Changed 8 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

I would go for the MS Word behavior, which is actually different. It removes the style from the current "word" (it expands the selection the word boundaries (including spaces).

In any case, this patch certainly needs updates.

comment:9 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Confirmed removed

comment:10 in reply to:  8 Changed 8 years ago by Garry Yao

Replying to fredck:

I would go for the MS Word behavior...

I can tell Microsoft Word Version 14 (2010) matches exactly the expected behavior described in ticket, which version are u having the above results?

comment:11 Changed 8 years ago by Frederico Caldeira Knabben

I'm using Word 2007.

Anyway, at this stage, let's wait for outsiders feedback first.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy