Opened 16 years ago
Closed 16 years ago
#2997 closed Bug (fixed)
FF : Toolbar combo contents flickers when opening
Reported by: | Frederico Caldeira Knabben | Owned by: | Frederico Caldeira Knabben |
---|---|---|---|
Priority: | Must have (possibly next milestone) | Milestone: | CKEditor 3.0 |
Component: | General | Version: | |
Keywords: | Confirmed Firefox Review+ | Cc: |
Description
When opening a toolbar combo for the first time, it's possible to briefly see its contents with no style which immediately gets re-rendered with the styles applied.
This is noticeable in Firefox only.
Attachments (4)
Change History (13)
comment:1 Changed 16 years ago by
Keywords: | Review? added |
---|
Changed 16 years ago by
Attachment: | 2997.patch added |
---|
comment:2 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
Changed 16 years ago by
Attachment: | 2997_2.patch added |
---|
comment:3 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
I like the "Loading..." solution :)
comment:4 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|---|
Owner: | set to Frederico Caldeira Knabben |
Status: | new → assigned |
I think I was not clear enough in my comment regarding inline style. The patch is definitely wrong, as it makes the styles hardcoded.
I'll provide a new patch for it.
Changed 16 years ago by
Attachment: | 2997_3.patch added |
---|
comment:6 follow-up: 7 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
why not simplify it further?
html .cke_container
instead of
body .cke_container, body.cke_container
Changed 16 years ago by
Attachment: | 2997_4.patch added |
---|
comment:7 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
Replying to alfonsoml:
why not simplify it further? (... code)
Good one. In any case, we recently made changes to that exact CSS rule, making it correctly skin aware. So, I'm adding a new special generic class name (cke_<skin_name>_container) which can be used to these cases, when you don't want the reset CSS to be active.
comment:8 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
Right now, I would opt for a simpler solution for this. We could use the same approach we are using for the editor and the dialog, by simply adding an inline style into the panel, which gets them overridden by a style in the editor CSS. Much probably this would be enough.
If we understand that the "Loading..." solution is need instead, we can return back to the proposed patch.