Opened 10 years ago

Closed 10 years ago

#2997 closed Bug (fixed)

FF : Toolbar combo contents flickers when opening

Reported by: Frederico Caldeira Knabben Owned by: Frederico Caldeira Knabben
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed Firefox Review+ Cc:

Description

When opening a toolbar combo for the first time, it's possible to briefly see its contents with no style which immediately gets re-rendered with the styles applied.

This is noticeable in Firefox only.

Attachments (4)

2997.patch (2.7 KB) - added by Artur Formella 10 years ago.
2997_2.patch (2.8 KB) - added by Artur Formella 10 years ago.
2997_3.patch (1.1 KB) - added by Frederico Caldeira Knabben 10 years ago.
2997_4.patch (1.6 KB) - added by Frederico Caldeira Knabben 10 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 10 years ago by Artur Formella

Keywords: Review? added

Changed 10 years ago by Artur Formella

Attachment: 2997.patch added

comment:2 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

Right now, I would opt for a simpler solution for this. We could use the same approach we are using for the editor and the dialog, by simply adding an inline style into the panel, which gets them overridden by a style in the editor CSS. Much probably this would be enough.

If we understand that the "Loading..." solution is need instead, we can return back to the proposed patch.

Changed 10 years ago by Artur Formella

Attachment: 2997_2.patch added

comment:3 Changed 10 years ago by Artur Formella

Keywords: Review? added; Review- removed

I like the "Loading..." solution :)

comment:4 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed
Owner: set to Frederico Caldeira Knabben
Status: newassigned

I think I was not clear enough in my comment regarding inline style. The patch is definitely wrong, as it makes the styles hardcoded.

I'll provide a new patch for it.

Changed 10 years ago by Frederico Caldeira Knabben

Attachment: 2997_3.patch added

comment:5 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review? added; Review- removed

KISS

comment:6 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review- added; Review? removed

why not simplify it further?

 	html .cke_container 

instead of

	body .cke_container, 
	body.cke_container 

Changed 10 years ago by Frederico Caldeira Knabben

Attachment: 2997_4.patch added

comment:7 in reply to:  6 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review? added; Review- removed

Replying to alfonsoml:

why not simplify it further? (... code)

Good one. In any case, we recently made changes to that exact CSS rule, making it correctly skin aware. So, I'm adding a new special generic class name (cke_<skin_name>_container) which can be used to these cases, when you don't want the reset CSS to be active.

comment:8 Changed 10 years ago by Garry Yao

Keywords: Review+ added; Review? removed

comment:9 Changed 10 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: assignedclosed

Fixed with [3221].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy