Opened 11 years ago

Closed 11 years ago

#2999 closed Bug (fixed)

Bad performance on selection change checks

Reported by: Frederico Caldeira Knabben Owned by: Garry Yao
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed Cc:

Description

There is a really bad performance in the tasks being fired when the selection changes in the editor. To check it:

  1. Clean load a sample.
  2. With a mouse click, place the cursor inside any unformatted word, like "are".
  3. Open the Firebug console and start a Profile job. Don't do anything in the editor, not even a mouseover in the toolbar buttons.
  4. Click inside a bold word, like "sample". Again, don't do anything else in the editor.
  5. Stop the Profile job.

The profiler will show you an excessive number of calls.

In IE6 this bad performance is terribly noticeable, compromising the editor usage.

Performance excellence is definitely important for this feature.

Change History (3)

comment:1 Changed 11 years ago by Garry Yao

This is related to #2927, which raise the state computation to O(n2), where n stand for number of commands.

comment:2 Changed 11 years ago by Garry Yao

Owner: set to Garry Yao
Status: newassigned

The patch in #2927 could almost resolve the bug on this ticket.

comment:3 Changed 11 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: assignedclosed

The situation is much more stable now. There may be room for improvements, but this is not anymore a critical issue.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy