Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#3 closed Task (fixed)

Merge fck_1.js and fck_2.js to fck.js

Reported by: Frederico Caldeira Knabben Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone: FCKeditor 2.4
Component: General Version:
Keywords: Cc:

Description

In the past, we have used a different loading system that separated the code in three files. We have understood that it doesn't gave us so much in the loading performance, and the method has been changed. Now we have just one file with all the code.

To better organize the code, we must now merge the fck_1.js and fck_2.js files (and their respective browser specific implementations) to the fck.js file.

Change History (5)

comment:1 Changed 11 years ago by Alfonso Martínez de Lizarrondo

Owner: set to Alfonso Martínez de Lizarrondo
Status: newassigned

comment:2 Changed 11 years ago by Alfonso Martínez de Lizarrondo

I've committed the changes to my branch, I've tried to put everything under the FCK object as other new code instead of just leaving as FCK.

The basic test that I've done seem to work without problems

comment:3 Changed 11 years ago by Frederico Caldeira Knabben

It seams to be everything ok with the merge. I'm just worried about the order things get executed. But actually nothing happens until the StartEditor function is called.

The only way to be sure we are loading things in the right order, is by defining a dependency map. Actually, the FCKScriptLoader is here for that, but it is still incomplete. I'm opening ticket #44 for that.

Maybe it is a good idea to move it to trunk. In this way, both of us will be testing it during other developments.

comment:4 Changed 11 years ago by Alfonso Martínez de Lizarrondo

Resolution: fixed
Status: assignedclosed

I've commited the changes to the trunk. When I did the changes I moved the fckevents.js order because that was the only file that I saw as a direct dependency that was called during the load, the rest of the code was definition of the functions so it doesn't matter if the objects are still loaded or not and I didn't want to mess too much.

comment:5 Changed 11 years ago by Frederico Caldeira Knabben

Milestone: FCKeditor 2.4
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy