Opened 8 years ago

Closed 8 years ago

#3009 closed Bug (fixed)

Enhance testing framework to support async 'setUp'

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.1
Component: QA Version: 3.0 Beta 2
Keywords: Confirmed HasTest Cc:

Description (last modified by Garry Yao)

In functional tests where always requires to have a fully interacted editor instance as prerequisites, with all tests in a case share a 'playground' instance.

We should provide a customized TestSuite which responsible for setting up a editor instance transparently with all containing TCs share this singleton, with this, it even able to make sure each test 's cleanness in a TC by resetting the editor with TestCase::setUp.

Since the setting up of our editor is always an asynchronous operation, so does cleaning up an editor sometimes, sadly that YUI doesn't support calling wait/resume inside setUp method, we should work around it in order to bring the above functionality into truth.

Attachments (3)

3009.patch (3.9 KB) - added by Garry Yao 8 years ago.
3009_2.patch (2.7 KB) - added by Garry Yao 8 years ago.
3009_3.patch (3.9 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 8 years ago by Garry Yao

Keywords: Confirmed added
Owner: set to Garry Yao
Status: newassigned

comment:2 Changed 8 years ago by Garry Yao

Description: modified (diff)

Revised to a new approach to work arround this.

Changed 8 years ago by Garry Yao

Attachment: 3009.patch added

comment:3 Changed 8 years ago by Garry Yao

Keywords: Review? added

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Component: GeneralQA
Milestone: CKEditor 3.0

comment:5 Changed 8 years ago by Alfonso Martínez de Lizarrondo

Version: SVN (FCKeditor)CKEditor 3.0 Beta 2

comment:6 Changed 8 years ago by Garry Yao

Keywords: HasPatch added; Review? removed
Milestone: CKEditor 3.1

The correct way is having a dedicated 'YAHOO.tool.TestSuite' instead of 'YAHOO.tool.TestCase', any editor based TCs should be grouped into it.

Changed 8 years ago by Garry Yao

Attachment: 3009_2.patch added

comment:7 Changed 8 years ago by Garry Yao

Keywords: HasTest Review? added; HasPatch removed

comment:8 Changed 8 years ago by Garry Yao

Description: modified (diff)

Update description according to recent investigation.

Changed 8 years ago by Garry Yao

Attachment: 3009_3.patch added

comment:9 Changed 8 years ago by Garry Yao

The new path contains the following changes:

  1. Enable 'wait/resume' support in 'setUp' for both TestSuite/TestCase;
  2. Decouple YUI Test enhancement to dedicated YUI extension.
  3. Update TC with [4106].

comment:10 Changed 8 years ago by Garry Yao

Keywords: Review? removed

Changes committed with [4147] at CKEditor and [4148] at CKTester.

comment:11 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy