plugin:form fields certain attributes not commited in IE

[Garry Yao]

Specifically, attributes name,style and check box based options didn't get committed.

Functional Testcase

Provide a test case for checkbox, others field types could also be reproduced in same way.

[Garry Yao]

Functional Testcase

[Artur Formella]

It is very strange.

var element2 = CKEDITOR.dom.element.createFromHtml( '<input name="bbbbbbb"></input>' );
element2.$.setAttribute( 'name', 'ccccccc' );
element2.$.name= 'ddddddd';
element2.setAttribute( 'name', 'aaaaaaa' );

alert(element2.getNameAtt() ); 		// IE returns aaaaaaa
alert(element2.$.name ); 		// IE returns aaaaaaa
alert(element2.$.getAttribute('name') ); // IE returns aaaaaaa
alert(element2.getAttribute('name') ); 	// IE returns bbbbbbb
alert(element2.getOuterHtml());		// IE returns <INPUT name="bbbbbbb" _cke_expando=237></INPUT>
	

var element3 = CKEDITOR.dom.element.createFromHtml( '<input test="bbbbbbb"></input>' );
element3.setAttribute( 'test', 'aaaaaaa' );

alert(element3.getAttribute('test') ); 	// returns aaaaaaa
alert(element3.getOuterHtml());		// returns <INPUT test="aaaaaaa" _cke_expando=239></INPUT>
	

In FF, webkit and opera works fine

[Garry Yao]

Unit Test Case

[Garry Yao]

Replying to arczi: As indicate by Artur, this's been a ​browser bug from IE, I'm attaching the TC for it, but I guess we can't relay on IE for it, probably it could be fixed by utilize expando property .

[Martin Kou]

Review- because:

1. The patch didn't fix the checkbox bug.
2. The patch is causing JavaScript error in selection field dialog.

I'm taking over the ticket.

[Martin Kou]

Quite a lot of problems were found with the forms plugin with the previous patch, and were fixed in the new proposed patch:

1. Checkboxes in radio and checkbox dialogs don't work.
2. JavaScript error in selection field dialog.
3. Attribute values are not removed when they're cleared by the user in dialog.
4. Setting the "value" attribute in all form element dialogs do not work.
5. Changing the "type" attribute in all applicable form element dialogs in IE causes JavaScript errors.
6. When editing text areas in IE with out cols and rows attributes specified, the text field dialog would still display "20" and "4" as the attribute values.
7. Similarly, the size and maxlength attributes are being displayed as "20" and "2147483647"in the text field dialog in IE even though the attributes don't exist in HTML.
8. The logic of the "Value" text field in selection dialog isn't complete (it's still left as a TODO).
9. The form dialog does not edit forms in IE because of wrong selected element detection logic.

[Martin Kou]

#3070 is marked as a dup to this ticket because the proposed patch fixes it as well.

[Garry Yao]

As discussed with Martin, a new method of 'hasAttribute' will be introduced to eliminate the default value checking under IE.

[Garry Yao]

#3403 is opening for this problem.

[Martin Kou]

Fixed with [3407].

Click here for more info about our SVN system.