Opened 16 years ago
Closed 16 years ago
#3403 closed Task (fixed)
Adding 'hasAttribute' method
Reported by: | Garry Yao | Owned by: | Martin Kou |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.0 |
Component: | General | Version: | |
Keywords: | Confirmed Review+ | Cc: |
Description
There's some cases where it's necessary to check whether a attributed is intrinsic OR assigned dynamically on an element.
Attachments (4)
Change History (13)
comment:1 Changed 16 years ago by
Owner: | set to Martin Kou |
---|
comment:2 Changed 16 years ago by
Status: | new → assigned |
---|
Changed 16 years ago by
Attachment: | 3403.patch added |
---|
comment:3 Changed 16 years ago by
Keywords: | Review? added |
---|
This removes the ieDefaults hacks in the forms plugin cleanly.
Changed 16 years ago by
Attachment: | test_element_hasAttribute.patch added |
---|
comment:4 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
The new method doesn't cover certain special attributes in sense of the attached TC in IE.
Changed 16 years ago by
Attachment: | 3403_2.patch added |
---|
comment:5 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
I'm not sure if this is worth it - the core code size is being increased to check for fringe cases. But anyway this should pass the tests.
comment:6 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
You are right Martin, we don't need it by default into the core.
Let's proceed in this way... let's have a basic implementation in the core and then override it inside the forms plugin, for IE only.
Changed 16 years ago by
Attachment: | 3403_3.patch added |
---|
comment:7 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:8 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
comment:9 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Fixed with [3438].
Click here for more info about our SVN system.
Much of our dialog fields play the role of the getter/setter of the DOM element node attribute, and we always use the following way to check the existence of a specified attribute:
It works in most cases but has one problem: