plugin:colorbutton incorrect state after color selected.

[Garry Yao]

The bgColor and textColor button should have no states after applying the styles. Currently we can still found sometimes these two buttons toggled on after panel is closed.

[Frederico Caldeira Knabben]

See #3163 for information on how to reproduce it.

[Garry Yao]

When adding the following lines arround _source\plugins\panelbutton\plugin.js for debugging, it is found that the 'CKEDITOR.TRISTATE_OFF' state is incorrectly applied to 'text-color' when hidding the 'bg-color' panel.

		this._.__defineSetter__( 'state', function( state ){
			console.log( this.id );
			return state;
		} );

[Garry Yao]

The bug was found to be caused by some incorrect handler function caching.

[Frederico Caldeira Knabben]

While this fix even makes sense, as we have a reference to "panel" that can't be shared by all buttons, it makes no difference for me. I can reproduce the problem in the same way before and after the patch:

1. Click the "Background Color" button.
2. Click the "Foreground Color" button.
3. Click the "Background Color" twice. The "Foreground Color" button remains hilighted.

This looks like an issue with the floating panel system, as something similar can be done with the combos also.

In any case, please move the "clickFn" variable declaration from line 16 to line 71 at this point and commit your changes. A final solution is still to be found though.

[Artur Formella]

Replying to fredck:

1. Click the "Background Color" button.
2. Click the "Foreground Color" button.
3. Click the "Background Color" twice. The "Foreground Color" button remains hilighted.

Patch from #3219 fixes this bug.

[Garry Yao]

Committed the patch with [3323].

[Artur Formella]

I'm taking over the ticket after talk with Garry.

[Artur Formella]

It was a part of ​http://dev.fckeditor.net/attachment/ticket/3068/3068_2.patch

This is the simplest way, is solves also #3222.

[Artur Formella]

Fixed with [3552]