Accessibility not complete on toolbar items

[Garry Yao]

Certain toolbar items are not correctly with title and tabIndex.

[Artur Formella]

In test case itemElement.getAttribute( 'title' ) is a string or a null and it is impossible to get 'true'.

It should be changed to:

assert.isTrue( !!itemElement.getAttribute( 'title' ),
'Toolbar item ' + col + ' doesn\'t have description title.');

[Garry Yao]

Functional Test Case

[Garry Yao]

This one is going to be fixed along with #3073.

[Frederico Caldeira Knabben]

Replying to garry.yao:

This one is going to be fixed along with #3073.

No it's not. #3073 is supposed to handle the TAB move over the toolbar only. We still need to make the combos contents accessible:

1. TAB to combo and hit ENTER to open it (#3073). The combo panel opens with no options selected.
2. Use ( ARROW-DOWN | TAB ) && ( ARROW-UP | SHIFT-TAB) to move through the panel items. (It should simply stop when hitting the first/last item).
3. ENTER key to execute the item (should be ready already).
4. or ESC to close the panel and return the focus back to the combo.

Points 2, 3 and 4 are not handled by #3073.

[Garry Yao]

Replying to fredck:

Points 2, 3 and 4 are not handled by #3073.

The patch take care of the missing features.

[Garry Yao]

IE's not expecting keydown on Window, so register this event on Document instead.

[Frederico Caldeira Knabben]

Your patch is quite interesting. I was tending to accept it, but it came to my eyes that it would be much better if the key handling logic would be contained by the block itself, instead of the richcombo. In this way, we could reuse it for other blocks, like the color selectors or the context menu.

There were also other things missing in this patch, like the keys support in the color selectors. There were also some fixes to the coding style, as well as simplifications that could be done.

Due to the extreme urgency we have for this ticket, I'll be coming with a new patch for it.

[Frederico Caldeira Knabben]

This new patch is supposed to fix "all" issues regarding the toolbar combos and color selectors accessibility.

[Garry Yao]

The patch has the following problems:

1. BOM is attaching to plugin.js file in both 'richCombo' and 'listBlock';
2. The logic at Line 265 of _source/plugins/panel/plugin.js is counting invisible list item, which cause the first two 'arrowDown' key within Styles Combo been absorbed, it's better to bypass those items;
3. The 'focusIndex' is not correct in colorbutton panel, which always start at the position of last focused box , no matter if the box is selected.

[Frederico Caldeira Knabben]

Replying to garry.yao:

1. BOM is attaching to plugin.js file in both 'richCombo' and 'listBlock';

Many of of files have the BOM. This thing doesn't need to be checked as it is supposed to be made uniform during the release process.

In any case, I believe the new patch doesn't have it.

1. The logic at Line 265 of _source/plugins/panel/plugin.js is counting invisible list item, which cause the first two 'arrowDown' key within Styles Combo been absorbed, it's better to bypass those items;

It looks like we can't rely on styles for this check. I've changed it.

1. The 'focusIndex' is not correct in colorbutton panel, which always start at the position of last focused box , no matter if the box is selected.

The panel now resets it before showing the block.

[Garry Yao]

In Webkit, Esc not working with Text Color panel, when pressed, the focus is not returned to button link, works for Bg Color though.

[Frederico Caldeira Knabben]

Replying to garry.yao:

In Webkit, Esc not working with Text Color panel, when pressed, the focus is not returned to button link, works for Bg Color though.

This is not critical. We can have a ticket for it as soon as this one gets committed.

[Frederico Caldeira Knabben]

Fixed with [3226].