Opened 16 years ago
Closed 16 years ago
#3077 closed Bug (fixed)
Tools: createClass incompleteness
Reported by: | Garry Yao | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.0 |
Component: | General | Version: | SVN (FCKeditor) - Retired |
Keywords: | Confirmed Review+ | Cc: |
Description (last modified by )
CKEDITOR.tools.createClass logic's not right in the following sense:
- Generally class creation need to fix contructor property, which is wrong after prototype copying;
- Private fields should be available in constructor;
Attachments (4)
Change History (10)
Changed 16 years ago by
Attachment: | 3077.patch added |
---|
comment:1 Changed 16 years ago by
Description: | modified (diff) |
---|---|
Keywords: | Confirmed Review? added |
Owner: | set to Garry Yao |
Status: | new → assigned |
Changed 16 years ago by
Attachment: | 3077_2.patch added |
---|
comment:2 Changed 16 years ago by
Changed 16 years ago by
Attachment: | 3077_3.patch added |
---|
comment:4 Changed 16 years ago by
Description: | modified (diff) |
---|
comment:5 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
comment:6 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
The proposed patch for private fields has impacted legacy codes which need to fix also.