Opened 10 years ago

Closed 10 years ago

#3077 closed Bug (fixed)

Tools: createClass incompleteness

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Confirmed Review+ Cc:

Description (last modified by Garry Yao)

CKEDITOR.tools.createClass logic's not right in the following sense:

  • Generally class creation need to fix contructor property, which is wrong after prototype copying;
  • Private fields should be available in constructor;

Attachments (4)

3077.patch (1.6 KB) - added by Garry Yao 10 years ago.
3077_2.patch (3.2 KB) - added by Garry Yao 10 years ago.
test-tools-createClass.patch (5.2 KB) - added by Garry Yao 10 years ago.
Unit Test Case
3077_3.patch (3.1 KB) - added by Garry Yao 10 years ago.

Download all attachments as: .zip

Change History (10)

Changed 10 years ago by Garry Yao

Attachment: 3077.patch added

comment:1 Changed 10 years ago by Garry Yao

Description: modified (diff)
Keywords: Confirmed Review? added
Owner: set to Garry Yao
Status: newassigned

Changed 10 years ago by Garry Yao

Attachment: 3077_2.patch added

comment:2 Changed 10 years ago by Garry Yao

The proposed patch for private fields has impacted legacy codes which need to fix also.

Changed 10 years ago by Garry Yao

Unit Test Case

Changed 10 years ago by Garry Yao

Attachment: 3077_3.patch added

comment:3 Changed 10 years ago by Garry Yao

Cutting off unnecessary changes after discuss with Fred.

comment:4 Changed 10 years ago by Garry Yao

Description: modified (diff)

comment:5 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:6 Changed 10 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [3188]. Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy