Opened 18 years ago
Closed 18 years ago
#3085 closed Bug (fixed)
Accessibility: Menu
| Reported by: | Garry Yao | Owned by: | Frederico Caldeira Knabben |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | General | Version: | SVN (FCKeditor) - Retired |
| Keywords: | Confirmed Oracle Review+ | Cc: |
Description
Menu( Context Menu currently) should has some same navigation mechanism with drop-down control like RichCombo.
Attachments (5)
Change History (15)
comment:1 Changed 18 years ago by
| Keywords: | Oracle added |
|---|
comment:2 Changed 18 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | new → assigned |
Changed 18 years ago by
| Attachment: | 3085.patch added |
|---|
comment:3 Changed 18 years ago by
| Keywords: | Confirmed Review? added |
|---|
Changed 18 years ago by
| Attachment: | 3085_2.patch added |
|---|
comment:4 Changed 18 years ago by
comment:5 Changed 18 years ago by
| Keywords: | Review- added; Review? removed |
|---|---|
| Owner: | changed from Garry Yao to Frederico Caldeira Knabben |
| Status: | assigned → new |
This patch is a partial fix for this ticket. There are still some things missing:
- The focus must be moved back to the editor on ESC.
- There must be a way to display the context menu with the keyboard.
- In IE, the menu items are not being highlighted when moving over them with the keyboard.
I've already coded all this. I'll be attaching a new patch here for review.
Changed 18 years ago by
| Attachment: | 3085_3.patch added |
|---|
comment:6 Changed 18 years ago by
| Keywords: | Review? added; Review- removed |
|---|---|
| Status: | new → assigned |
This patch fixes all mentioned issues. It registers the SHIFT+F10 as the context menu keystroke. This is the default keystroke for context menu activation on Windows.
Changed 18 years ago by
| Attachment: | 3085_4.patch added |
|---|
comment:7 Changed 18 years ago by
The provided patch still have problem with IE selection problem, the new patch is only about adding the fix to this.
Changed 18 years ago by
| Attachment: | 3085_5.patch added |
|---|
comment:8 Changed 18 years ago by
The previous patch was not saving the selection in IE when using the keyboard to open the context menu. Also, it was forcing the selection saving over all browsers, and it's better to limit it to those that need it only (IE).
The new patch fix all these issues.
comment:9 Changed 18 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
Fix keycode value.