Opened 10 years ago

Closed 10 years ago

#3085 closed Bug (fixed)

Accessibility: Menu

Reported by: Garry Yao Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Confirmed Oracle Review+ Cc:

Description

Menu( Context Menu currently) should has some same navigation mechanism with drop-down control like RichCombo.

Attachments (5)

3085.patch (1.2 KB) - added by Garry Yao 10 years ago.
3085_2.patch (1.2 KB) - added by Garry Yao 10 years ago.
3085_3.patch (5.3 KB) - added by Frederico Caldeira Knabben 10 years ago.
3085_4.patch (6.0 KB) - added by Garry Yao 10 years ago.
3085_5.patch (6.0 KB) - added by Frederico Caldeira Knabben 10 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 10 years ago by Senthil

Keywords: Oracle added

comment:2 Changed 10 years ago by Garry Yao

Owner: set to Garry Yao
Status: newassigned

Changed 10 years ago by Garry Yao

Attachment: 3085.patch added

comment:3 Changed 10 years ago by Garry Yao

Keywords: Confirmed Review? added

Changed 10 years ago by Garry Yao

Attachment: 3085_2.patch added

comment:4 Changed 10 years ago by Garry Yao

Fix keycode value.

comment:5 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed
Owner: changed from Garry Yao to Frederico Caldeira Knabben
Status: assignednew

This patch is a partial fix for this ticket. There are still some things missing:

  • The focus must be moved back to the editor on ESC.
  • There must be a way to display the context menu with the keyboard.
  • In IE, the menu items are not being highlighted when moving over them with the keyboard.

I've already coded all this. I'll be attaching a new patch here for review.

Changed 10 years ago by Frederico Caldeira Knabben

Attachment: 3085_3.patch added

comment:6 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review? added; Review- removed
Status: newassigned

This patch fixes all mentioned issues. It registers the SHIFT+F10 as the context menu keystroke. This is the default keystroke for context menu activation on Windows.

Changed 10 years ago by Garry Yao

Attachment: 3085_4.patch added

comment:7 Changed 10 years ago by Garry Yao

The provided patch still have problem with IE selection problem, the new patch is only about adding the fix to this.

Changed 10 years ago by Frederico Caldeira Knabben

Attachment: 3085_5.patch added

comment:8 Changed 10 years ago by Frederico Caldeira Knabben

The previous patch was not saving the selection in IE when using the keyboard to open the context menu. Also, it was forcing the selection saving over all browsers, and it's better to limit it to those that need it only (IE).

The new patch fix all these issues.

comment:9 Changed 10 years ago by Garry Yao

Keywords: Review+ added; Review? removed

comment:10 Changed 10 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: assignedclosed

Fixed with [3247].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy