Opened 16 years ago
Closed 16 years ago
#3091 closed Bug (fixed)
plugin:font change font cross table incorrect
Reported by: | Garry Yao | Owned by: | Frederico Caldeira Knabben |
---|---|---|---|
Priority: | Must have (possibly next milestone) | Milestone: | CKEditor 3.0 |
Component: | General | Version: | SVN (FCKeditor) - Retired |
Keywords: | Confirmed Review+ | Cc: |
Description
Procedures
- Open the replace by code example page;
- Initial the document with the following content and selection:
^outter<table><tr><td>text</td></tr></table>outter^
- Apply different fonts three times with the same range.
- Actual Result : The document result in:
<span style="font-family: Courier New,Courier,monospace;">outter</span> <table> <tbody> <tr> <td> <span style="font-family: Courier New,Courier,monospace;">text</span></td> </tr> </tbody> </table> <table> <tbody> <tr> <td> </td> </tr> </tbody> </table> <span style="font-family: Courier New,Courier,monospace;">outter</span>
Attachments (3)
Change History (12)
comment:1 follow-up: 2 Changed 16 years ago by
comment:2 Changed 16 years ago by
Keywords: | Confirmed added |
---|---|
Summary: | plugin:font not correct after apply multiple times → plugin:font change font cross table incorrect |
Replying to garry.yao:
I've tested solely with style system which shows no bug, perhaps the bug comes from selection system, just guess.
The bug was actually caused by the style system proved by the attached unit test file.
comment:3 Changed 16 years ago by
Priority: | Normal → High |
---|
comment:4 Changed 16 years ago by
Owner: | set to Garry Yao |
---|---|
Status: | new → assigned |
Changed 16 years ago by
Attachment: | 3091.patch added |
---|
comment:5 Changed 16 years ago by
Keywords: | Review? added |
---|
The problem was due to the invoke to removeFromInsideElement on line 438 will probably remove the startNode which is used as a reference for judging whether an inline element is inside the range.
comment:6 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|---|
Owner: | changed from Garry Yao to Frederico Caldeira Knabben |
Status: | assigned → new |
This patch breaks several tests at "_source/tests/plugins/styles/styles.html".
I have investigated this issue a lot today and found out that the culprit is a feature I've introduced when porting the style system from V2.
Changed 16 years ago by
Attachment: | 3091_2.patch added |
---|
comment:7 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:8 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
The patch resolve the issue in another simple way.
I've tested solely with style system which shows no bug, perhaps the bug comes from selection system, just guess.