plugin:stylesCombo has no options

[Garry Yao]

Procedures

1. Open the replace by code example page;
2. Initial the document with the following content and selection:

   ^<ol><li>item</li></ol>^
   

3. Click on stylesCombo to open drop-down.

• Actual Result: No options are listed in the drop-down.

[Garry Yao]

The same case happened when there's only a table inside content:

<table>
	<tbody>
		<tr>
			<td>
				text</td>
		</tr>
	</tbody>
</table>

[Frederico Caldeira Knabben]

I can't reproduce this. Can you confirm it?

[Garry Yao]

It's a FF only issue.

[Garry Yao]

It's necessary to check on element path for BOTH inline and block style, the patch remove the condition which skip the elementpath checking.

[Garry Yao]

After some discussion with Fred,it's confirmed that it should be able for the user to fully select on block element (mostly by click on elementpath bar for that) and apply the dedicating styles, including specific styles which were apply to the block itself, and more generic styles which were applied to it's content.
Currently we have some special cases in IE where certain elements is unselectable ( e.g. 'tr' and 'tbody'), caused by CKEDITOR.dom.selection::selectElement invoking will have no effect with these elements.
While we're seaking for workaround for the above bug, this patch here fix the other problem on the other side inside the styleCombo, which prevent styles options been shown if selecting a block element.

[Frederico Caldeira Knabben]

The idea is ok. There are two small optimizations that could be done in the code, which are result of the change:

• As we may have the "element" variable, the elementPath creation should consider it. So we could have the following at line 161:

elementPath = new CKEDITOR.dom.elementPath( element || selection.getStartElement() );

• As we now always have the elementPath variable created, the if check at line 185 and its relative else block are not anymore needed.

[Frederico Caldeira Knabben]

The patch is almost good. There is just a minor issue, as elementPath is now being declared twice in the var statement.

[Garry Yao]

Fixed with [3494].