Opened 11 years ago

Closed 11 years ago

#3130 closed Bug (fixed)

Tabspaces setting in tab plugin is not working

Reported by: Martin Kou Owned by: Martin Kou
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Oracle Review+ Cc: Senthil

Description

To reproduce:

  1. Set config.tabSpaces=4 in config.js.
  2. Open replacebyclass.html in IE or Firefox.
  3. Put focus into editing area.
  4. Press tab.
  5. Nothing happens.

In Senthil's demonstration this evening, what happened was the editor put 4 spaces while blurring itself and put focus into the next field - but that's also wrong.

Attachments (1)

3130.patch (495 bytes) - added by Martin Kou 11 years ago.

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by Martin Kou

Attachment: 3130.patch added

comment:1 Changed 11 years ago by Martin Kou

Keywords: Review? added

The logic for handling tabSpaces is simply not handled at all - it was marked as a TODO in an empty block in the trunk.

I've added a simple implementation that seems to work ok in Firefox and IE. I guess Senthil has added an external tab key handler in their code which is causing the NBSPs to be added - that handler should be removed after applying this patch.

comment:2 Changed 11 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

Correct. The tab plugin was one one the first things to reach the code. At that moment we didn't have insertHtml ready for it, so it got marked as TODO.

The solution is as simple as this patch.

comment:3 Changed 11 years ago by Martin Kou

Resolution: fixed
Status: newclosed

Fixed with [3233].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy