Opened 16 years ago
Last modified 15 years ago
#3133 review_failed Bug
insertElement incorrect after deleteContents
Reported by: | Garry Yao | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | General | Version: | 3.0 Beta 2 |
Keywords: | Confirmed | Cc: |
Description (last modified by )
If there's a insertion happened after the selection range content is deleted, the inserted element is at the end instead of in the front.
Take the smiley plugin for reproducing:
- Make the content and selection as below:
<p>te^xt</p> <ul> <li>te^xt</li> </ul>
- Open the smiley plugin to insert a motion;
- Expected Result:
<p>te<img alt=":)" title=":)" ...></p><ul><li>xt</li></ul>
- Actual Result:
<p>te</p><img alt=":)" title=":)" ...><ul><li>xt</li></ul>
Attachments (3)
Change History (20)
comment:1 Changed 16 years ago by
comment:2 Changed 16 years ago by
Description: | modified (diff) |
---|---|
Keywords: | Confirmed added |
Updated the bug symptom with current trunk.
comment:3 follow-up: 4 Changed 16 years ago by
Please do not change the ticket description in this way. If anything changed, you can add comments for it.
In this specific case for example, your original ticket text was much more useful to understand the bug (the js error is just another issue here).
comment:4 Changed 16 years ago by
Description: | modified (diff) |
---|
Replying to fredck:
Please do not change the ticket description in this way. If anything changed, you can add comments for it.
In this specific case for example, your original ticket text was much more useful to understand the bug (the js error is just another issue here).
Revert to the old description.
Changed 16 years ago by
Attachment: | 3133.patch added |
---|
comment:5 Changed 16 years ago by
Keywords: | Review? added |
---|---|
Owner: | set to Garry Yao |
Status: | new → assigned |
The proposed path will insert those inline elements at the original editable end after deletion instead of the collapsed position.
Changed 16 years ago by
Attachment: | 3313_2.patch added |
---|
comment:6 Changed 16 years ago by
The correct carot position should be at the original editable start instead.
comment:7 follow-up: 8 Changed 16 years ago by
The below line might be confusing since it's relay on the buggy 'getBoundaryNodes', which report the result nodes up-side-down on collapsed range(#3292).
comment:8 Changed 16 years ago by
Replying to garry.yao:
// Place the editing carot after the editing end of previous node. range.moveToElementEditEnd( range.getBoundaryNodes().endNode );
comment:9 Changed 16 years ago by
Milestone: | CKEditor 3.0 → CKEditor 3.1 |
---|
comment:10 Changed 15 years ago by
Version: | SVN (FCKeditor) → CKEditor 3.0 Beta 2 |
---|
comment:11 Changed 15 years ago by
Please refresh patch to newest trunk, as there are conflicts right now. Also, the patch filename contains wrong ticket number.
comment:12 Changed 15 years ago by
Keywords: | Review- added; Review? removed |
---|
Changed 15 years ago by
Attachment: | 3133_3.patch added |
---|
comment:13 Changed 15 years ago by
Keywords: | Review? added; Review- removed |
---|
Ticket Test added at :
http://ckeditor.t/tt/3313/1.html.
comment:14 Changed 15 years ago by
Milestone: | CKEditor 3.1 → CKEditor 3.2 |
---|
comment:16 Changed 15 years ago by
Keywords: | Review- added; Review? removed |
---|---|
Milestone: | CKEditor 3.2 → CKEditor 3.x |
This patch needs updates again, as it's not anymore "applyable" into trunk.
I think you have inverted the "expected" and "actual" results, right?