Opened 15 years ago

Closed 15 years ago

#3148 closed Task (fixed)

Implement a simpler way for loading external plugin JavaScript files

Reported by: Martin Kou Owned by: Frederico Caldeira Knabben
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.0
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Oracle Review+ Cc: Senthil


External plugin files are often not named plugin.js, so that CKEDITOR.plugins.addExternal() don't work for them.

The current solution is that the web app developer using CKEditor would define a separate function called CKEDITOR_GETURL() that will scan for patterns of his files and output the correct URL.

While the approach works, it is still too complicated and error-prone for many web app developers. A simpler way is needed to enable external plugins with arbitrary file names to be loaded.

Attachments (2)

3148.patch (2.8 KB) - added by Frederico Caldeira Knabben 15 years ago.
3148_2.patch (4.8 KB) - added by Garry Yao 15 years ago.

Download all attachments as: .zip

Change History (6)

Changed 15 years ago by Frederico Caldeira Knabben

Attachment: 3148.patch added

comment:1 Changed 15 years ago by Frederico Caldeira Knabben

Keywords: Review? added
Status: newassigned

With the proposed patch, addExternal accepts a third optional parameter for the file name. If not provided, the default name is used.

Changed 15 years ago by Garry Yao

Attachment: 3148_2.patch added

comment:2 Changed 15 years ago by Garry Yao

I've added test case along with the patch.

comment:3 Changed 15 years ago by Martin Kou

Keywords: Review+ added; Review? removed

comment:4 Changed 15 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: assignedclosed

Fixed with [3245].

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy