Opened 9 years ago

Closed 9 years ago

#3171 closed Bug (fixed)

plugin:flash incorrect content inserted

Reported by: Garry Yao Owned by: Garry Yao
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

Reproducing Procedures

  1. Open the replace by code example page;
  2. Delete all the content within document;
  3. Open flash dialog and fill in url with : http://f.friendster-tweakers.com/rsc/swf/clock/fsdbp.swf, specify width with '100', height with '100', click Ok to insert the flash.
  • Actual Result : The style is been attached to the wrapping paragraph element.
    <p>
    	<p height="100" width="100">
    		<object classid="clsid:d27cdb6e-ae6d-11cf-96b8-444553540000" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,40,0" height="100" width="100"><param name="quality" value="high"></param><param name="movie" value="http://f.friendster-tweakers.com/rsc/swf/clock/fsdbp.swf"></param><embed height="100" pluginspage="http://www.macromedia.com/go/getflashplayer" quality="high" src="http://f.friendster-tweakers.com/rsc/swf/clock/fsdbp.swf" type="application/x-shockwave-flash" width="100"></embed></object></p>
    	<br />
    </p>
    
  • Expected Result :
    <p>
    		<object classid="clsid:d27cdb6e-ae6d-11cf-96b8-444553540000" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,40,0" height="100" width="100"><param name="quality" value="high"></param><param name="movie" value="http://f.friendster-tweakers.com/rsc/swf/clock/fsdbp.swf"></param><embed height="100" pluginspage="http://www.macromedia.com/go/getflashplayer" quality="high" src="http://f.friendster-tweakers.com/rsc/swf/clock/fsdbp.swf" type="application/x-shockwave-flash" width="100"></embed></object>
    	<br />
    </p>
    

Attachments (2)

3171.patch (3.0 KB) - added by Garry Yao 9 years ago.
3171_2.patch (731 bytes) - added by Garry Yao 9 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 9 years ago by Garry Yao

Also happened to other fake elements as well.

comment:2 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Confirmed added
Priority: NormalHigh

comment:3 Changed 9 years ago by Garry Yao

Owner: set to Garry Yao
Status: newassigned

Changed 9 years ago by Garry Yao

Attachment: 3171.patch added

comment:4 Changed 9 years ago by Garry Yao

Keywords: Review? added

Beside the fake element issue, the patch also fix a preview area clear up bug.

comment:5 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed
  • Please do not include the "preview area clear up" fix into this patch. Actually it's wrong, and it could block this ticket form being fixed (onHide should be used... see #3205).
  • The fix is correct. Please also remove the "filter" parameter from the function, as it's wrong and not used.

Changed 9 years ago by Garry Yao

Attachment: 3171_2.patch added

comment:6 Changed 9 years ago by Garry Yao

Keywords: Review? added; Review- removed

I'll open a new ticket for the preview area issue.

comment:7 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:8 Changed 9 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [3298]. Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy