Opened 16 years ago
Closed 16 years ago
#3205 closed Bug (fixed)
Image dialog problem after close
Reported by: | Garry Yao | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.0 |
Component: | General | Version: | |
Keywords: | Confirmed Review+ | Cc: |
Description
Reproducing Procedures
- Open the replace by class example page;
- Click on 'Image' dialog button to open dialog;
- Click on 'Cancel' button to close the dialog;
- Actual Result: An JavaScript Error thrown;
Attachments (2)
Change History (10)
Changed 16 years ago by
Attachment: | 3205.patch added |
---|
comment:1 Changed 16 years ago by
Keywords: | Review? added |
---|---|
Status: | new → assigned |
comment:3 Changed 16 years ago by
Actually there's some ambiguity with 'onHide' event which is actually fired after the dialog closed, the dialog system will unfortunately remove the dialog element from DOM temporarily, which cause subsequent update catch a 'element not found' error.
It's better for this case if there's a 'onBeforeHide' event which will certainly promising, but hooking it in 'onOk' and 'onCancel' conform to KISS as well.
comment:4 follow-up: 5 Changed 16 years ago by
Oh, yes. I've found it.
onHide() in the dialog without access to the dialog is less useful and less intuitive.
End-developers might have problems with that.
I think dialog should be removed after onHide is called.
comment:5 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
Replying to arczi:
I think dialog should be removed after onHide is called.
You are correct Artur... that's the right way for it.
Changed 16 years ago by
Attachment: | 3205_2.patch added |
---|
comment:6 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:7 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
comment:8 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Refine the logic of clearing the preview area, which caused the error.