Opened 16 years ago
Closed 16 years ago
#3190 closed Bug (fixed)
Auto-fix block-less paragraphs
Reported by: | Frederico Caldeira Knabben | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.0 |
Component: | General | Version: | |
Keywords: | Confirmed 3.0RC Review+ | Cc: |
Description
When moving the caret inside the editor (on selectionChange), the editor could automatically fix paragraphs with no blocks, resulting in a more accurate WYSIWYG experience, as after all the paragraphs will be fixed on output.
Attachments (7)
Change History (19)
comment:1 Changed 16 years ago by
Priority: | High → Normal |
---|
Changed 16 years ago by
Attachment: | 3190.patch added |
---|
comment:2 Changed 16 years ago by
Keywords: | Review? added |
---|---|
Owner: | changed from Frederico Caldeira Knabben to Garry Yao |
Status: | new → assigned |
Changed 16 years ago by
Attachment: | 3190_2.patch added |
---|
comment:4 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
We already have a function for it: range::fixBlock. You should try using it.
Changed 16 years ago by
Attachment: | 3190_3.patch added |
---|
comment:5 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:6 Changed 16 years ago by
Keywords: | 3.0RC added |
---|
comment:7 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
After talking with Garry, we've found out that the patch is doing more than needed, and can be simplified.
Changed 16 years ago by
Attachment: | 3190_4.patch added |
---|
comment:8 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
I've identified some other problem with the patch though:
Sometimes it's troublesome to have a range start within a bookmark node, e.g. extractContent/insertNode will duplicate the bookmark node which will result in weird result, the patch is proposing a fix to the this case by the 'optimizeBookmark' function.
Changed 16 years ago by
Attachment: | 3190_5.patch added |
---|
comment:9 Changed 16 years ago by
Keywords: | Confirmed Review? 3.0RC → Confirmed 3.0RC Review? |
---|
Including the related latest patch from #3180 for easy reviewing.
Changed 16 years ago by
Attachment: | 3190_6.patch added |
---|
Changed 16 years ago by
Attachment: | 3190_7.patch added |
---|
comment:10 Changed 16 years ago by
Fixing several issues encountered during peer reviewing with Fred.
comment:11 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
The following steps could be used to test the functionality.
Procedures