Opened 11 years ago

Closed 11 years ago

#3191 closed Bug (fixed)

Make the dialog system skin-independent

Reported by: Martin Kou Owned by: Martin Kou
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.0
Component: UI : Dialogs Version: SVN (CKEditor) - OLD
Keywords: Review+ Cc:

Description

The dialog system is currently tightly coupled with the default skin, which makes it difficult to change the skin to something else.

Fred has written a patch for fix this. The patch involved quite a number of drastic changes, however, which resulted in some functional bugs still to be fixed:

  • Tabs are not working.
  • Footer buttons not always get aligned right with IE.
  • Dialog size in Safari 3 when tabs are displayed.
  • Dialog drag-move, in general, specially in IE.

And then the CKEDITOR.dialog.setMargins() should be moved to skin.js as part of the skin definition.

Attachments (3)

dialog.patch (46.8 KB) - added by Martin Kou 11 years ago.
3191.patch (49.9 KB) - added by Martin Kou 11 years ago.
3191_2.patch (65.9 KB) - added by Martin Kou 11 years ago.

Download all attachments as: .zip

Change History (10)

Changed 11 years ago by Martin Kou

Attachment: dialog.patch added

comment:1 Changed 11 years ago by Martin Kou

More things that need to be fixed:

  • Scrollbars appearing in dialogs in IE
  • Wrong layout for the smiley and special characters dialog in all browsers.

comment:2 Changed 11 years ago by Martin Kou

Keywords: Review? added

Changed 11 years ago by Martin Kou

Attachment: 3191.patch added

comment:3 Changed 11 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

The final patch is mostly ok. Two things are missing though:

  • CKEDITOR.dialog.setMargins() should be moved into skin.js as part of the skin definition.
  • The dialog can be moved to outside the page at right and left.

comment:4 Changed 11 years ago by Frederico Caldeira Knabben

  • The dialog is not getting centered when opened. Also, the margins must be considered in the centralization calculation.

Changed 11 years ago by Martin Kou

Attachment: 3191_2.patch added

comment:5 Changed 11 years ago by Martin Kou

Keywords: Review? added; Review- removed

comment:6 Changed 11 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

The dialog centering issue is still there. I'll open a new ticket for it.

comment:7 Changed 11 years ago by Martin Kou

Resolution: fixed
Status: newclosed

Fixed with [3276].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy