Opened 8 years ago

Closed 8 years ago

#3282 closed Bug (fixed)

Skin files are not being loaded with timestamp

Reported by: Frederico Caldeira Knabben Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

Looking at file requests in nightly build (skins) sample, it's possible to note that the skin.js file and the main CSS files don't have the timestamp ("t") parameter in the URL. We must ensure this parameter is properly sent to the server.

Attachments (2)

3282.patch (1.1 KB) - added by Garry Yao 8 years ago.
3282_2.patch (955 bytes) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by Garry Yao

Owner: set to Garry Yao
Status: newassigned

Changed 8 years ago by Garry Yao

Attachment: 3282.patch added

comment:2 Changed 8 years ago by Garry Yao

Keywords: Review? added

comment:3 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

The patch is broken. I'm not able to apply it.

Even though, the changes look by reading the patch file directly. But, I would prefer applying it for a final check.

Changed 8 years ago by Garry Yao

Attachment: 3282_2.patch added

comment:4 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

Not sure why the original patch is broken.

comment:5 Changed 8 years ago by Martin Kou

Keywords: Review+ added; Review? removed

comment:6 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [3380].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy