CKPackager creates invalid JavaScript

[Josh Nisly]

When packing the en.js lang file, the packager mungers the file in such a way to cause the JavaScript Lint tool to complain. The specific problem is that in the "colors" object, it removes the quotes from the members. For example, "'008080' : 'Teal'," becomes "008080:'Teal',".

[Frederico Caldeira Knabben]

I've confirmed it in the nightly build. Some of the color entries are inside single quotes, while others don't have it. We should have some checks that automatically add the quotes if the name starts with a number.

Actually, I would take a look at the ECMA specs to properly check whether or not to have quotes there.

[Wiktor Walc]

In the Ecma-262 specs (7.8.3 Numeric Literals), we have the following:

NumericLiteral ::
DecimalLiteral
HexIntegerLiteral

and later on:

DecimalLiteral ::
DecimalIntegerLiteral...
(...)

DecimalIntegerLiteral ::
0
NonZeroDigit DecimalDigitsopt

..so only 0 and numbers starting with 1-9 are ok. Because numbers starting with 0 are treated as octal numbers (Annex B, B.1.1), I think all we need to do is to modify regular expression in CKPackager and put numbers in single quotes if they start with '0'.

[Frederico Caldeira Knabben]

The fix looks good. I've added some tests for it with the new patch. Please use it for committing, if you think the changes are good.

[Wiktor Walc]

Fixed with [3501] and [3502] (I have used the second patch with tests included).